This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Allow overriding docker build environment variables #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to build heron in an environment that does not include the git repository (this can be the case in ci for instance). We should allow people building override the derived variables to manually set the version.
|
There is actually a heron version string that is passed in whose purpose was to be the version that the release was tagged with. What are peoples thoughts about either
or
It appears that |
|
Ship it! |
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
It is possible to build heron in an environment that does not include the git repository (this can be the case in ci for instance). We should allow people building override the derived variables to manually set the version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to build heron in an environment that does not include
the git repository (this can be the case in ci for instance). We should
allow people building override the derived variables to manually set the
version.