This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Python topology submission/execution support #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
taishi8117
commented
Aug 9, 2016
taishi8117
commented
- Heron-cli can submit python topology as described in Added docs for Python topology support #1231
| topology_class = pex_loader.import_and_get_class(topology_pex, topology_class_name) | ||
| topology_class.write() | ||
| except Exception: | ||
| traceback.print_exc() |
There was a problem hiding this comment.
do you want to use Log.debug(traceback.print_exc())
|
It looks fine to me - rest of the stuff 👍 (once you fix the comment) |
| heron_env['HERON_OPTIONS'] = opts.get_heron_config() | ||
|
|
||
| args = [topology_pex] | ||
| Log.debug('$> %s' % ' '.join(args)) |
There was a problem hiding this comment.
joining a list of one element?
There was a problem hiding this comment.
also, better rename it to cmd. args does not make sense to me.
objmagic
pushed a commit
to taishi8117/heron
that referenced
this pull request
Aug 10, 2016
* Python topology submission/execution support
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
* Python topology submission/execution support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.