This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
move cli, explorer, tracker and ui and tools common files #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this breaks since the hardcoded level is changed: |
| @@ -151,7 +151,7 @@ def get_heron_dir_explorer(): | |||
| From heron-cli with modification since we need to reuse cli's conf | |||
| :return: root location for heron-cli. | |||
| """ | |||
There was a problem hiding this comment.
btw, why do we need this? Isn't this the same as the get_heron_dir()?
taishi8117
changed the title
|
heron-ui is still not working |
taishi8117
changed the title
|
ui, tracker, cli and explorer are working. Let me know if this PR is good to go. |
|
👍 LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
into heron/tools