Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Repacking to use globally unique task ids #1377

Merged
merged 3 commits into from
Sep 13, 2016

Conversation

billonahill
Copy link
Contributor

Repacking was reusing global task ids (i.e., restarting from 1) for new instnaces added. This caused strange tuple routing behavior.

Opened #1376 to not rely on instanceIndex parsed from instanceId.

@billonahill
Copy link
Contributor Author

@avflor let me know what you think.

@avflor
Copy link
Contributor

avflor commented Sep 13, 2016

@billonahill I reviewed the code a few hours ago. It looks good. Thanks for catching the bug with the globaltaskIndex!

@billonahill billonahill merged commit f8b317d into apache:master Sep 13, 2016
@billonahill billonahill deleted the billg/repack_unique_task_ids branch September 13, 2016 03:52
@billonahill billonahill self-assigned this Sep 14, 2016
@billonahill billonahill added this to the 0.14.4 milestone Sep 14, 2016
moomou pushed a commit to moomou/heron that referenced this pull request Sep 15, 2016

* increment when adding

* link to issue
nicknezis pushed a commit that referenced this pull request Sep 14, 2020

* increment when adding

* link to issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants