This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Change executor to not assume contiguous container id set #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moomou
pushed a commit
to moomou/heron
that referenced
this pull request
Sep 15, 2016
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During scaling if we remove a container the executor will break, since it assumes contiguous container ids from 0..N. Instead we should take container ids from the container plan.
cc/ @avflor @ashvina
Required for #1292.