This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add driver memory config for yarn scheduler #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
billonahill
reviewed
Sep 29, 2016
| @@ -153,6 +155,7 @@ private Configuration getHMDriverConf() { | |||
| .set(HeronDriverConfiguration.HTTP_PORT, 0) | |||
| .set(HeronDriverConfiguration.VERBOSE, false) | |||
| .set(YarnDriverConfiguration.QUEUE, queue) | |||
| .set(DriverConfiguration.DRIVER_MEMORY, driverMemory) | |||
There was a problem hiding this comment.
this could be for another PR, but it would be great to have a unit test that loads things up and verifies the default configs, then another one that loads things up with overrides and verifies that too. Such a test would verify that this .set call wasn't overlooked.
There was a problem hiding this comment.
Good point. I have some ideas to test the yarnconfigs. Will create an issue to track it separately. Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1446