This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add support for SSH sock proxying to scheduler #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maosongfu
reviewed
Sep 29, 2016
|
|
||
| # SSH tunnel host | ||
| heron.scheduler.tunnel.host: "my.tunnel.host" |
There was a problem hiding this comment.
Add a new line at the end?
| heron.statemgr.tunnel.verify.count: 10 | ||
|
|
||
| # SSH tunnel host | ||
| heron.statemgr.tunnel.host: "my.tunnel.host" |
There was a problem hiding this comment.
Add a new line at the end?
| private NetworkUtils() { | ||
| } | ||
|
|
||
| public static class TunnelConfig { |
There was a problem hiding this comment.
Should we make it separate class or a nested class?
There was a problem hiding this comment.
I could go either way on this. I made it an inner class since it's tightly couple to, and only intended for, NetworkUtils but if we think it should stand on it's own I'm ok with it.
|
looks good to me. 👍 |
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
* Add newlines at the end of configs * Fix unit test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1412 we ran into a need for socks proxying from the scheduler to TMaster. This patch fixes that by creating two tunneling approaches: port forwarding (existing behavior required for ZK since ZK client doesn't support proxies) and sock proxy (preferred approach for tunneling HTTP).
The previous tunneling approach was written specifically for ZK. This pulls the tunneling configs out of ZK and into it's own config loader that can be used by state manager, scheduler, etc. See
NetworkUtilsandShellUtilsfor the bulk of the changes.Also removed a few occurances of
verboseflags, which were not used and should be replaces by the logging level controls that now handle that.Related to #1292.