This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
combine log.warning of tunnelHost into exception message #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billonahill
reviewed
Oct 17, 2016
| @@ -77,8 +77,7 @@ public void initialize(Config newConfig) { | |||
|
|
|||
| String newConnectionString = tunneledResults.first; | |||
| if (newConnectionString.isEmpty()) { | |||
| LOG.warning("Cannot connect to tunnelHost: " + tunnelConfig.getTunnelHost()); | |||
| throw new IllegalArgumentException("Bad connectionString: " + connectionString); | |||
| throw new IllegalArgumentException("Cannot connect to tunnelHost: " + tunnelConfig.getTunnelHost() + "\nBad connectionString: " + connectionString); | |||
There was a problem hiding this comment.
let's remove the newline from the exception message. This complicates log parsing when grepping or using loglens.
|
👍 once CI is fixed. |
Please fix CI error. |
ashvina
pushed a commit
to ashvina/heron
that referenced
this pull request
Nov 9, 2016
* combine log.warning of tunnelHost into exception message * remove newline in exception message * fix CI error
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
* combine log.warning of tunnelHost into exception message * remove newline in exception message * fix CI error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.