This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Move methods from PackingUtils into PackingPlanBuilder #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will review that tomorrow |
|
@billonahill The changes look good to me. |
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
* revert change to retry num attempts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that logic is centralized in the builder there are methods in utils that are only used by the builder which we can make private in the builder.
Various other cleanup of unused code.
No logic changes here, just moving things around.