This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Change local integration tests to use test status objects instead of True/False #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
objmagic
suggested changes
Nov 10, 2016
| logging.error("Test failed, attempting to clean up") | ||
| self.cleanup_test() | ||
| raise e | ||
| except Exception as e: |
There was a problem hiding this comment.
duplicate except ... as e?
There was a problem hiding this comment.
That's ok since e is scoped within each except clause so only 1 will be defined without collision.
| if topology_submitted: | ||
| logging.error("Test failed, attempting to clean up") | ||
| self.cleanup_test() | ||
| return status.TestFailure("Exception thrown during test", e) |
There was a problem hiding this comment.
how about using try .. except .. finally clause? https://docs.python.org/2.7/tutorial/errors.html#defining-clean-up-actions
There was a problem hiding this comment.
Yes, good call.
|
besides comments and style issues, 👍 👍 👍 👍 👍 |
objmagic
approved these changes
Nov 10, 2016
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
…True/False (#1546) * fix checkstyles * Fixing checkstyles and using finally block
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration test frameworks return True/False, or sometimes "success"/"fail" to denote a successful or failed test. This changes that so tests can either return a
Successobject or raise aTestFailureexception.This simplifies the code because all methods in the chain no longer need to check for True/False and log before proceeding. Instead tests proceed assuming success and handle the failure exceptions if thrown. We also don't need topology cleanup calls scattered about, since we can just catch the failure and clean up.
This changes the local integration test, but I plan to change the remote tests similarly in another PR.