This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
cleanup glog build file #1636
Merged
cleanup glog build file #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlu90
reviewed
Dec 21, 2016
| "include/glog/stl_logging.h", | ||
| "include/glog/vlog_is_on.h", | ||
| ], | ||
| srcs = ["empty.cc"] + lib_files, |
There was a problem hiding this comment.
The include files are in the hdrs now. Realized this is not needed in the srcs actually.
nlu90
approved these changes
Dec 21, 2016
| "include/glog/stl_logging.h", | ||
| "include/glog/vlog_is_on.h", | ||
| ], | ||
| srcs = ["empty.cc"] + lib_files, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up glog third party build to separate include files and lib files in a separate list. Appropriately name execution scripts