This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add null check when heron reads the config file #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
origin 1861 link |
huijunw
changed the title
objmagic
changed the title
billonahill
reviewed
Jan 31, 2017
| @@ -66,7 +66,7 @@ public void dump(TopologyAPI.Component.Builder bldr) { | |||
| for (Map.Entry<String, Object> entry : componentConfiguration.entrySet()) { | |||
| TopologyAPI.Config.KeyValue.Builder kvBldr = TopologyAPI.Config.KeyValue.newBuilder(); | |||
| kvBldr.setKey(entry.getKey()); | |||
| kvBldr.setValue(entry.getValue().toString()); | |||
| kvBldr.setValue(entry.getValue() == null ? "null" : entry.getValue().toString()); | |||
There was a problem hiding this comment.
Let's put null in there instead of "null".
|
👍 |
1 similar comment
|
👍 |
|
Did you test it locally with null config-value? @huijunw |
|
updated. tested. For the null value in the map, there are 4 options:
Thanks for @maosongfu suggestion. |
|
👍 |
maosongfu
reviewed
Feb 2, 2017
| @@ -64,6 +66,10 @@ public void dump(TopologyAPI.Component.Builder bldr) { | |||
|
|
|||
| TopologyAPI.Config.Builder cBldr = TopologyAPI.Config.newBuilder(); | |||
| for (Map.Entry<String, Object> entry : componentConfiguration.entrySet()) { | |||
| if (entry.getValue() == null) { | |||
There was a problem hiding this comment.
Check entry.getKey() too since the key can also be null.
https://docs.oracle.com/javase/7/docs/api/java/util/Map.html#put(K,%20V)
|
Looks good to me. 👍 |
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
Add null check when heron reads the config file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add null check when Heron reads the config file. resolves #1681