This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Remove scheduler state manager adaptor requirement for submission dry-run #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
submission dry-run.
|
Also addressed some comments from @mycFelix in 1e34ccc |
billonahill
approved these changes
Feb 7, 2017
| @@ -381,6 +381,9 @@ public String createTable() { | |||
| } | |||
| } | |||
|
|
|||
| private static final List<String> titleNames = Arrays.asList( | |||
There was a problem hiding this comment.
psf should be TITLE_NAMES
huijunw
reviewed
Feb 8, 2017
| } else { | ||
| // initialize the state manager | ||
| statemgr.initialize(config); |
There was a problem hiding this comment.
looks good to me. it is expected like what the PR description says.
There was a problem hiding this comment.
you can add a reply next time instead of making an inline comment.
|
build is fine on CI, unit tests passed locally. Website build breaks the CI because of some package issues, which will be solved in #1703. merging now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dry-run submission does not need to use adaptor to scheduler state manager. With this PR, state manager initialization will not happen, which reduces dry-run of submission to Aurora from 10 seconds to 1.7 seconds.
resolves #1692