Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Remove special case CentOS build files #1725

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

objmagic
Copy link
Contributor

@objmagic objmagic commented Feb 19, 2017

for CentOS 7 build and general clean-up and refactoring

An internal PR (D28289) has also been submitted.

@objmagic objmagic added the build label Feb 19, 2017
@objmagic objmagic added this to the 0.14.6 milestone Feb 19, 2017
@objmagic objmagic self-assigned this Feb 19, 2017
@kramasamy
Copy link
Contributor

@objmagic - have you tested the package for centos7 before removing these files?

@huijunw
Copy link
Contributor

huijunw commented Feb 22, 2017

what were these 2 files originally for?

@objmagic
Copy link
Contributor Author

@huijunw because of Bazel's own issue, we have to write a separate BUILD file for CentOS 5 (and cannot reuse the one for Mac). This issue does not happen on CentOS 7. Since we are migrating to CentOS 7, we can remove these two historical files.

@huijunw
Copy link
Contributor

huijunw commented Feb 22, 2017

thanks @objmagic

@objmagic objmagic merged commit 045bd2c into apache:0.14.6 Feb 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants