Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Avoid duplicated metrics requests in Heron UI #3378

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Avoid duplicated metrics requests in Heron UI #3378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 50 additions & 40 deletions heron/tools/ui/resources/static/js/topologies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ var SUM = 0,
AVG = 1,
LAST = 2;

var countersUrlFlags = {};

var AllExceptions = React.createClass({
getInitialState: function() {
return {}
Expand Down Expand Up @@ -480,50 +482,58 @@ var AllMetrics = React.createClass({
},

fetchCountersURL: function(url, timeRange) {
$.ajax({
url: url,
dataType: 'json',
success: function(response) {
if (response.hasOwnProperty("metrics")) {
var component = response.component;
var metrics = this.metrics;
if (!metrics.hasOwnProperty(component)) {
metrics[response.component] = {};
}
if (!metrics[component].hasOwnProperty(timeRange)) {
metrics[component][timeRange] = {};
}
for (var name in response.metrics) {
if (response.metrics.hasOwnProperty(name)) {
var metricname = name;
// Handle __jvm-uptime-secs as a special case.
if (name !== "__jvm-uptime-secs") {
metricname = name.split("/")[0] + "/";
}
var displayName = this.supportedMetricNames[metricname].name;
if (!metrics[component][timeRange].hasOwnProperty(displayName)) {
metrics[component][timeRange][displayName] = {};
}
var tmpMetrics = {
metrics: response.metrics[name],
scaleDevisor: this.supportedMetricNames[metricname].scaleDevisor,
aggregationType: this.supportedMetricNames[metricname].aggregationType
};
if (name === "__jvm-uptime-secs") {
metrics[component][timeRange][displayName][""] = tmpMetrics;
} else {
metrics[component][timeRange][displayName][name.split("/")[1]] = tmpMetrics;
// This function might be called multiple times with the same url. Note
// that the timeRange value is inlcuded in the url so it can be ignored in
// the check. We check if the request has been made before first and
// skip if this is a duplicated request.
if (!countersUrlFlags[url]) {
countersUrlFlags[url] = true; // Set the flag

$.ajax({
url: url,
dataType: 'json',
success: function(response) {
if (response.hasOwnProperty("metrics")) {
var component = response.component;
var metrics = this.metrics;
if (!metrics.hasOwnProperty(component)) {
metrics[response.component] = {};
}
if (!metrics[component].hasOwnProperty(timeRange)) {
metrics[component][timeRange] = {};
}
for (var name in response.metrics) {
if (response.metrics.hasOwnProperty(name)) {
var metricname = name;
// Handle __jvm-uptime-secs as a special case.
if (name !== "__jvm-uptime-secs") {
metricname = name.split("/")[0] + "/";
}
var displayName = this.supportedMetricNames[metricname].name;
if (!metrics[component][timeRange].hasOwnProperty(displayName)) {
metrics[component][timeRange][displayName] = {};
}
var tmpMetrics = {
metrics: response.metrics[name],
scaleDevisor: this.supportedMetricNames[metricname].scaleDevisor,
aggregationType: this.supportedMetricNames[metricname].aggregationType
};
if (name === "__jvm-uptime-secs") {
metrics[component][timeRange][displayName][""] = tmpMetrics;
} else {
metrics[component][timeRange][displayName][name.split("/")[1]] = tmpMetrics;
}
}
}
metrics[component][timeRange]["__interval"] = response.interval;
this.setMetrics(metrics);
}
metrics[component][timeRange]["__interval"] = response.interval;
this.setMetrics(metrics);
}
}.bind(this),
}.bind(this),

error: function() {
}
});
error: function() {
}
});
}
},

render: function() {
Expand Down