Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Support Java 11 #3382

Closed
wants to merge 2 commits into from
Closed

Support Java 11 #3382

wants to merge 2 commits into from

Conversation

nwangtw
Copy link
Contributor

@nwangtw nwangtw commented Oct 27, 2019

Compiles ok with Java 11

@nwangtw nwangtw requested a review from ashvina October 27, 2019 06:40
@nwangtw
Copy link
Contributor Author

nwangtw commented Oct 27, 2019

#3266

@joshfischer1108
Copy link
Member

You might need to update the JDK version in the travis file too. https://github.com/apache/incubator-heron/blob/master/.travis.yml

@nwangtw
Copy link
Contributor Author

nwangtw commented Oct 28, 2019

You might need to update the JDK version in the travis file too. https://github.com/apache/incubator-heron/blob/master/.travis.yml

The change should work for Java8 and above

@nwangtw nwangtw force-pushed the nwang/java_11_support branch from 7c0eadf to b52d478 Compare October 28, 2019 00:49
@nwangtw
Copy link
Contributor Author

nwangtw commented Oct 29, 2019

Some unit test libraries are not Jdk11 compatible and need to be updated. :(

@joshfischer1108
Copy link
Member

It might be better to move this branch from your forked repo into the main heron repo. This way people can help us complete this task by opening up PR's directly to this branch.

@nwangtw
Copy link
Contributor Author

nwangtw commented Nov 1, 2019

It might be better to move this branch from your forked repo into the main heron repo. This way people can help us complete this task by opening up PR's directly to this branch.

Ah, interesting. That is a great idea~

Pushed to java_11_support branch.
To https://github.com/twitter/heron.git

  • [new branch] java_11_support -> java_11_support

@thinker0
Copy link
Member

#3399

@thinker0
Copy link
Member

#3434

@thinker0 thinker0 mentioned this pull request Feb 14, 2020
@nicknezis
Copy link
Contributor

Can this Pull Request be closed due to the work done by @thinker0 in #3399 and #3434 ?

@nwangtw nwangtw closed this Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants