Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Update zk version to 3.4.14 in dist and install zk in ubuntu 16/18 di… #3411

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Update zk version to 3.4.14 in dist and install zk in ubuntu 16/18 di… #3411

merged 3 commits into from
Dec 10, 2019

Conversation

nwangtw
Copy link
Contributor

@nwangtw nwangtw commented Nov 30, 2019

…st docker image

@nwangtw nwangtw mentioned this pull request Nov 30, 2019
Closed
@nwangtw nwangtw requested a review from kramasamy December 4, 2019 04:42
@nwangtw nwangtw self-assigned this Dec 4, 2019
@nicknezis
Copy link
Contributor

Looks good to me, but is there any value in keeping the Zookeeper version as a Docker build ARG? This change would lose that feature. Probably not a big deal.

@nwangtw
Copy link
Contributor Author

nwangtw commented Dec 7, 2019

Looks good to me, but is there any value in keeping the Zookeeper version as a Docker build ARG? This change would lose that feature. Probably not a big deal.

How it was used? It should be easy to add back.

@joshfischer1108
Copy link
Member

Overall this looks good to me. Straight forward and easy to read. I noticed several of the same changes in the different files for different distros which got me thinking. Do we really need to support all of these different versions of ubuntu containers? Or even further do we need to support ubunutu, centos, and debian? Wouldn't it be more efficient for us to have one "official" supported image?

@nwangtw
Copy link
Contributor Author

nwangtw commented Dec 9, 2019

Overall this looks good to me. Straight forward and easy to read. I noticed several of the same changes in the different files for different distros which got me thinking. Do we really need to support all of these different versions of ubuntu containers? Or even further do we need to support ubunutu, centos, and debian? Wouldn't it be more efficient for us to have one "official" supported image?

Agreed. This is a reasonable question to discuss.

@nwangtw nwangtw merged commit 340e654 into apache:master Dec 10, 2019
sreev pushed a commit to sreev/incubator-heron that referenced this pull request Apr 9, 2020
@nwangtw @sreev
Update zk version to 3.4.14 in dist and install zk in ubuntu 16/18 di… (
5d3085b 
apache#3411)

* Update zk version to 3.4.14 in dist and install zk in ubuntu 16/18 dist docker image

* fix path

* Add back docker ARG
nicknezis pushed a commit that referenced this pull request Sep 14, 2020
@nwangtw
Update zk version to 3.4.14 in dist and install zk in ubuntu 16/18 di… (
66c656a 
#3411)

* Update zk version to 3.4.14 in dist and install zk in ubuntu 16/18 dist docker image

* fix path

* Add back docker ARG
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshfischer1108 joshfischer1108 joshfischer1108 approved these changes

@kramasamy kramasamy Awaiting requested review from kramasamy

@huijunwu huijunwu Awaiting requested review from huijunwu

@nlu90 nlu90 Awaiting requested review from nlu90

@xiaoyao1991 xiaoyao1991 Awaiting requested review from xiaoyao1991

Assignees

@nwangtw nwangtw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwangtw @nicknezis @joshfischer1108