Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Helm update to v3 #3430

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Conversation

nicknezis
Copy link
Contributor

Updated Helm to 3.0.2. Also updated the website documentation related to Helm.

Copy link
Contributor

@nwangtw nwangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I am not familiar with Helm. I will wait and see if anyone else with more experience can double-check.

Copy link
Member

@joshfischer1108 joshfischer1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM with one comment


```bash
$ helm init
$ helm repo add heron-charts https://storage.googleapis.com/heron-charts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this google bucket exists anymore. I wonder if we should modify the instructions to build and deploy from the source. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a bad idea. I had to figure it out on my own and having the bazel build target to generate-helm-charts documented would be nice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I agree. I'll wait to see if anyone else has any feedback.

@joshfischer1108 joshfischer1108 merged commit 485b708 into apache:master Jan 10, 2020
sreev pushed a commit to sreev/incubator-heron that referenced this pull request Apr 9, 2020
@nicknezis nicknezis deleted the nicknezis/helm-update branch April 16, 2020 05:25
nicknezis added a commit that referenced this pull request Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants