-
Notifications
You must be signed in to change notification settings - Fork 594
Helm update to v3 #3430
Helm update to v3 #3430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I am not familiar with Helm. I will wait and see if anyone else with more experience can double-check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM with one comment
|
||
```bash | ||
$ helm init | ||
$ helm repo add heron-charts https://storage.googleapis.com/heron-charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this google bucket exists anymore. I wonder if we should modify the instructions to build and deploy from the source. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not a bad idea. I had to figure it out on my own and having the bazel build
target to generate-helm-charts
documented would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I agree. I'll wait to see if anyone else has any feedback.
Updated Helm to 3.0.2. Also updated the website documentation related to Helm.