-
Notifications
You must be signed in to change notification settings - Fork 594
Improve docker dev env script #3441
Improve docker dev env script #3441
Conversation
It would be good to add this feature into the documentation somehow. Otherwise new users will not know it exists. |
I really like this change. Thank you. I kept running I've been wondering if something like Vagrant would be a more full approach to do this. Either way this change makes the development cycle much more pleasant. |
Thanks~ Vagrant is an interesting idea. It seems to be more powerful and can build a multiple nodes environment but it seems heavier than docker to me. Anyway, it could be useful to make development env setup easier. |
Yeah. I think now it is easy enough to use and will be included in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. And yes it is easy enough to use. ** If ** people know it exists.
cbf81ed
to
efd2772
Compare
The existing script can be used to create a docker image/container of the heron dev environment. However, raw docker commands are needed to go back to the same container. A new script is added to make it easier to use the container dev environment, so that deverlopers can create a container with:
dev-env-create.sh NAME
and return to the container (or start a new shell) with:
dev-env-run.sh NAME