Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Improve docker dev env script #3441

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

nwangtw
Copy link
Contributor

@nwangtw nwangtw commented Jan 29, 2020

The existing script can be used to create a docker image/container of the heron dev environment. However, raw docker commands are needed to go back to the same container. A new script is added to make it easier to use the container dev environment, so that deverlopers can create a container with:

dev-env-create.sh NAME

and return to the container (or start a new shell) with:
dev-env-run.sh NAME

@joshfischer1108
Copy link
Member

It would be good to add this feature into the documentation somehow. Otherwise new users will not know it exists.

@nicknezis
Copy link
Contributor

I really like this change. Thank you. I kept running docker system prune to clear out old containers.

I've been wondering if something like Vagrant would be a more full approach to do this. Either way this change makes the development cycle much more pleasant.

@nwangtw
Copy link
Contributor Author

nwangtw commented Feb 2, 2020

I really like this change. Thank you. I kept running docker system prune to clear out old containers.

I've been wondering if something like Vagrant would be a more full approach to do this. Either way this change makes the development cycle much more pleasant.

Thanks~ Vagrant is an interesting idea. It seems to be more powerful and can build a multiple nodes environment but it seems heavier than docker to me. Anyway, it could be useful to make development env setup easier.

@nwangtw
Copy link
Contributor Author

nwangtw commented Feb 2, 2020

It would be good to add this feature into the documentation somehow. Otherwise new users will not know it exists.

Yeah. I think now it is easy enough to use and will be included in the documentation.

Copy link
Member

@joshfischer1108 joshfischer1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. And yes it is easy enough to use. ** If ** people know it exists.

@joshfischer1108
Copy link
Member

@nwangtw we can fix the CI build if we merge #3442 . Then you can pull those changes in to this branch.

@nwangtw nwangtw force-pushed the nwang/improve_docker_dev_env_script branch from cbf81ed to efd2772 Compare February 3, 2020 04:20
@nwangtw
Copy link
Contributor Author

nwangtw commented Feb 3, 2020

@nwangtw we can fix the CI build if we merge #3442 . Then you can pull those changes in to this branch.

cool.thx.

@nwangtw nwangtw merged commit 3b66e97 into apache:master Feb 3, 2020
sreev pushed a commit to sreev/incubator-heron that referenced this pull request Apr 9, 2020
nicknezis pushed a commit that referenced this pull request Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants