Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Adding support of docker build for debian10 #3449

Closed
wants to merge 1 commit into from
Closed

Adding support of docker build for debian10 #3449

wants to merge 1 commit into from

Conversation

windhamwong
Copy link
Contributor

@windhamwong windhamwong commented Feb 10, 2020

The docker build for debian10 includes:

  • Using openjdk8 debian10 image, openjdk:8u242-jre-slim-buster
  • Default install Python3.7
  • Adding few lines of description of how to compile docker
  • Changing the example version to latest, to match the naming format

@joshfischer1108
Copy link
Member

joshfischer1108 commented Feb 10, 2020

@windhamwong Thank you for the start of this pull request. I was in the process of working through getting a Debian 9 Heron container ready for for the next release. Do you have a time estimate of when you think your contribution will be complete? I may hold off working on the Debian9 container if you feel that you are not far off from getting this ready for review.

@windhamwong
Copy link
Contributor Author

oh interesting situation. I am trying debian10 because debian9 docker build doesn't support Python 3.6+ due to lack of python-dev for 3.6+ version. (Or maybe I can sort out the source build thing but I can't find the source link) Let me try both debian9 and debian10 and come back :)

My debian10 commit is still having a huge break due to issue of protobuf bazel build. That's why the PR is still in draft.

@joshfischer1108
Copy link
Member

joshfischer1108 commented Feb 10, 2020

Well I wouldn't say the container is perfect yet. There is still some debugging to do. For example, I had to add in some environment variables when compiling the zookeeper target. I tried to add the environment variables only to the container to prevent needing to change the Bazel build targets, but adding them to the container didn't seem to fix the issue. On mac the build passes. On Debian9 it fails because the warnings that are thrown are treated as errors. I'm not exactly sure why yet. After adding those environment variables I was able to build a Debian9 container and submit an example ECO topology successfully. You can find the branch in this repo.. It is -> joshfischer/debian9.

@windhamwong
Copy link
Contributor Author

I didn't put any env or config for building docker. I believe if you see the warnings are treated as error, that means there is a major error before this line. The docker build is quite slow and I am reverting to debian9 build now as debian10 + protobuf update +python37 fails due to lack of library build (need time to build and fix).
I will come back when I have finished my build.

@windhamwong
Copy link
Contributor Author

Ok, I am working on debian9 now with the master configs. I do have an error here,

08:54:42 [WARN] /root/.cache/pants/setup/bootstrap-Linux-x86_64/1.23.0_py37/lib/python3.7/site-packages/pex/pep425tags.py:274: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses import imp

Is this the error you got?

@windhamwong
Copy link
Contributor Author

[Unrelated to the PR]
I have successfully deploy Python3.7.3 with Python37-dev to debian9. I am currently fixing the imp version.

[Related to PR]
The debian10 is having issue with bazel. I might retry again later to fix the issue before officially submit PR.

@windhamwong
Copy link
Contributor Author

Will merge with PR #3438 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants