This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 594
Support custom metrics rules for PrometheusSink #3493
Merged
nwangtw
merged 32 commits into
apache:master
from
thinker0:feature/support-custom-metrics-rules-for-prometheus-sink
Apr 2, 2020
Merged
Support custom metrics rules for PrometheusSink #3493
nwangtw
merged 32 commits into
apache:master
from
thinker0:feature/support-custom-metrics-rules-for-prometheus-sink
Apr 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support Java 11 * config travis to use oracle jdk 11 * Add check jdk version
Change insert gc_options Update list Fix gc-logging
* Support Java 11 * config travis to use oracle jdk 11 * Add check jdk version
Change insert gc_options Update list Fix gc-logging
…etheus-metrics' of https://github.com/thinker0/heron into feature/fix-prometheus-metrics * 'feature/fix-prometheus-metrics' of https://github.com/thinker0/heron: Remove unused Fix checkstyle Support jmx_exporter format configuration. wip Fix command arguments. Java 11 support (apache#3399) Update README for Java 11 (apache#3464) Update website for java 11 (apache#3462) Java 11 support (apache#3454) adding examples folder to classpath (apache#3458) removing symlink. Adding contributing guidelines back (apache#3450) adding new committers (apache#3451) Bump mixin-deep from 1.3.1 to 1.3.2 in /website2/website (apache#3391) Add redirect from github pages to new apache site (apache#3448) remove old site (apache#3446) Use netcat-bsd in Debian (apache#3447) Added execute permission to dev-env-create.sh (apache#3443) * 'feature/fix-prometheus-metrics' of https://github.com/thinker0/heron: Remove unused Fix checkstyle Support jmx_exporter format configuration. wip Fix command arguments. Java 11 support (apache#3399) Update README for Java 11 (apache#3464) Update website for java 11 (apache#3462) Java 11 support (apache#3454) adding examples folder to classpath (apache#3458) removing symlink. Adding contributing guidelines back (apache#3450) adding new committers (apache#3451) Bump mixin-deep from 1.3.1 to 1.3.2 in /website2/website (apache#3391) Add redirect from github pages to new apache site (apache#3448) remove old site (apache#3446) Use netcat-bsd in Debian (apache#3447) Added execute permission to dev-env-create.sh (apache#3443) # Conflicts: # .travis.yml
* master: Improve concurrency for needed parts. (apache#3107) Add documents for setting up a docker based development environment (apache#3475) Patch to fix cppcheck with newer glibc (apache#3471) Make log/sink/consume Streamlet component support setName and setNumPartitions (apache#3459)
* Change concurrent Map * Change concurrent Map * HashMap changes for unneeded parts. * HashMap changes for unneeded parts. * Review changes * Changes HashMap for unneeded parts. * Improve concurrency for needed parts. * Remove unused imports. * Remove unused imports. * Remove unused imports. * Fix NPE (cherry picked from commit 545d381) * Fix WhitespaceAround * Add dummy Object * Fix ConstantName (cherry picked from commit 8d6d506)
…hinker0/heron into feature/support-custom-metrics-rules-for-prometheus-sink * 'feature/fix-prometheus-metrics' of https://github.com/thinker0/heron: Add Rules Update kafkaOffset metrics Improve concurrency for needed parts. (apache#3107) Add documents for setting up a docker based development environment (apache#3475) Patch to fix cppcheck with newer glibc (apache#3471) Make log/sink/consume Streamlet component support setName and setNumPartitions (apache#3459)
nwangtw
approved these changes
Mar 21, 2020
@nicknezis how to retest this please |
@thinker0 I was able to restart the job for you. |
thinker0
deleted the
feature/support-custom-metrics-rules-for-prometheus-sink
branch
April 2, 2020 05:50
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Apr 9, 2020
* Support Java 11 * config travis to use oracle jdk 11 * Java 11 support (apache#3399) * Support Java 11 * config travis to use oracle jdk 11 * Add check jdk version * Fix command arguments. Change insert gc_options Update list Fix gc-logging * Add missing parameter * typo * Add pause time * wip * Support jmx_exporter format configuration. * Fix checkstyle * Remove unused * Java 11 support (apache#3399) * Support Java 11 * config travis to use oracle jdk 11 * Add check jdk version * Fix command arguments. Change insert gc_options Update list Fix gc-logging * wip * Support jmx_exporter format configuration. * Fix checkstyle * Remove unused * Update kafkaOffset metrics * Add Rules * Make log/sink/consume Streamlet component support setName and setNumPartitions (apache#3459) * Patch to fix cppcheck with newer glibc (apache#3471) * Add documents for setting up a docker based development environment (apache#3475) * Improve concurrency for needed parts. (apache#3107) * Change concurrent Map * Change concurrent Map * HashMap changes for unneeded parts. * HashMap changes for unneeded parts. * Review changes * Changes HashMap for unneeded parts. * Improve concurrency for needed parts. * Remove unused imports. * Remove unused imports. * Remove unused imports. * Fix NPE (cherry picked from commit 545d381) * Fix WhitespaceAround * Add dummy Object * Fix ConstantName (cherry picked from commit 8d6d506) * Update kafkaOffset metrics * Add Rules * Update line is longer than 100 characters * Update line is longer than 100 characters * Add attrNameSnakeCase or other metrics fix * fix checkstyle Co-authored-by: Ning Wang <wangninggm@gmail.com> Co-authored-by: Ning Wang <nwang@twitter.com> Co-authored-by: Nicholas Nezis <nicholas.nezis@gmail.com>
nicknezis
added a commit
that referenced
this pull request
Sep 14, 2020
* Support Java 11 * config travis to use oracle jdk 11 * Java 11 support (#3399) * Support Java 11 * config travis to use oracle jdk 11 * Add check jdk version * Fix command arguments. Change insert gc_options Update list Fix gc-logging * Add missing parameter * typo * Add pause time * wip * Support jmx_exporter format configuration. * Fix checkstyle * Remove unused * Java 11 support (#3399) * Support Java 11 * config travis to use oracle jdk 11 * Add check jdk version * Fix command arguments. Change insert gc_options Update list Fix gc-logging * wip * Support jmx_exporter format configuration. * Fix checkstyle * Remove unused * Update kafkaOffset metrics * Add Rules * Make log/sink/consume Streamlet component support setName and setNumPartitions (#3459) * Patch to fix cppcheck with newer glibc (#3471) * Add documents for setting up a docker based development environment (#3475) * Improve concurrency for needed parts. (#3107) * Change concurrent Map * Change concurrent Map * HashMap changes for unneeded parts. * HashMap changes for unneeded parts. * Review changes * Changes HashMap for unneeded parts. * Improve concurrency for needed parts. * Remove unused imports. * Remove unused imports. * Remove unused imports. * Fix NPE (cherry picked from commit 545d381) * Fix WhitespaceAround * Add dummy Object * Fix ConstantName (cherry picked from commit 8d6d506) * Update kafkaOffset metrics * Add Rules * Update line is longer than 100 characters * Update line is longer than 100 characters * Add attrNameSnakeCase or other metrics fix * fix checkstyle Co-authored-by: Ning Wang <wangninggm@gmail.com> Co-authored-by: Ning Wang <nwang@twitter.com> Co-authored-by: Nicholas Nezis <nicholas.nezis@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3445
Support custom metrics rules for PrometheusSink
AS-IS
TO-BE
Add metics_sink.yaml
to