This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Make Java optional in CLI and check JAVA_BIN #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. letting java experts to take a look. |
|
I'm no expert, but it looks good to me |
Code0x58
force-pushed
the
optional-cli-java
branch
from
8002fd2 to
56fe540
Compare
|
I made an amendment to use |
joshfischer1108
approved these changes
May 1, 2020
|
@Code0x58 It looks like there are some Python linting issues that are breaking the build. Would mind fixing those before we merge? |
Code0x58
force-pushed
the
optional-cli-java
branch
from
56fe540 to
d20d86b
Compare
Code0x58
force-pushed
the
optional-cli-java
branch
from
d20d86b to
69262e1
Compare
nicknezis
approved these changes
May 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so you only need the variables when they are used when submitting a topology, so you can still use other commands and check the
--help.It also uses
JAVA_BINbeforeJAVA_HOME.