This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Deep clean heron-admin - probably better to remove entirely #3584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started cleaning up
heron-admin
's code to make it a bit clearer, but along the way found that it was broken (at least because it tried to find nomad in the wrong place.Given all it does is try to manage one of many schedulers, when you can already use the local "cluster" or deploy your own cluster (including minikube or kind which seem to have support within the community), I'm thinking it would be better to strip out the
heron-admin
binary all together to simplify the ecosystem and reduce debt/maintenance cost as well.That said, the changes here are:
cl_args
dict everywhere$VISUAL
,$EDITOR
, orvi
when editing theinventory.yaml
inheron-admin standalone set