Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Unvendor #3603

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Unvendor #3603

merged 3 commits into from
Aug 14, 2020

Conversation

Code0x58
Copy link
Contributor

@Code0x58 Code0x58 commented Aug 12, 2020 •
edited
Loading

This unvendors:

  • kashmir - needed patch to use /dev/urandom instead of /dev/random
  • cpplint - upgraded to latest. Most new issues reported were excluded, but easy lint fixes were done in a separate commit

There is still third_party/python/semver which is used directly by ./bazel_configure.py, and third_party/java/jarjar which looks a bit suspicious (it only had a help.txt) so I left it alone to avoid breaking something.

@nicknezis nicknezis requested review from nwangtw and huijunwu August 14, 2020 17:45
@Code0x58 Code0x58 merged commit ee73293 into apache:master Aug 14, 2020
@Code0x58 Code0x58 deleted the unvendor branch August 14, 2020 19:03
nicknezis pushed a commit that referenced this pull request Sep 14, 2020
@Code0x58
Unvendor (#3603)
950ff6c 
* Unvendor kashmir

* Unvendor cpplint

* Fix cpplint issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicknezis nicknezis nicknezis approved these changes

@nwangtw nwangtw Awaiting requested review from nwangtw

@huijunwu huijunwu Awaiting requested review from huijunwu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Code0x58 @nicknezis