Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Fixes to heron-ui arg name changes #3634

Merged
merged 1 commit into from
Nov 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/kubernetes/general/tools.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ spec:
- >-
heron-ui
--port=8889
--base_url=/api/v1/namespaces/default/services/heron-ui:8889/proxy
--base-url=/api/v1/namespaces/default/services/heron-ui:8889/proxy
resources:
requests:
cpu: "100m"
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/helm/templates/tools.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ spec:
heron-ui
--port=8889
{{- if not (kindIs "invalid" .Values.heron.url) }}
--base_url={{ eq .Values.heron.url "-" | ternary $defaultUrl .Values.heron.url }}
--base-url={{ eq .Values.heron.url "-" | ternary $defaultUrl .Values.heron.url }}
{{- end }}
- name: heron-apiserver
image: {{ .Values.image }}
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/helm/values.yaml.template
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobReplicas: 1
# amount of memory to provide for API server
apiServerMemory: 512M
heron:
# set to `-` to set base_url to the default k8s proxy URL
# set to `-` to set base-url to the default k8s proxy URL
# set to `null` to remove the use of base_url
url: "-"
# Topologies uploader
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/minikube/tools.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ spec:
- >-
heron-ui
--port=8889
--base_url=/api/v1/namespaces/default/services/heron-ui:8889/proxy
--base-url=/api/v1/namespaces/default/services/heron-ui:8889/proxy
resources:
requests:
cpu: "100m"
Expand Down
6 changes: 3 additions & 3 deletions website2/docs/user-manuals-heron-ui.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ $ ./bazel-bin/heron/tools/ui/src/python/heron-ui
### Heron UI Args

* `--port` - Port to run the heron-ui on. Default port is `8889`.
* `--tracker_url` - The base url for tracker. All the information about the
* `--tracker-url` - The base url for tracker. All the information about the
topologies is fetched from tracker. Default url is `http://localhost:8888`.
* `--address` - Address to listen; Default address is `0.0.0.0`
* `--base_url` - The base url path if operating behind proxy; Default is [`None`](https://github.com/apache/incubator-heron/blob/master/heron/tools/ui/src/python/main.py#L145)
* `--base-url` - The base url path if operating behind proxy; Default is [`None`](https://github.com/apache/incubator-heron/blob/master/heron/tools/ui/src/python/main.py#L145)

```bash
$ heron-ui
# is equivalent to
$ heron-ui --port=8889 --tracker_url=http://localhost:8888
$ heron-ui --port=8889 --tracker-url=http://localhost:8888
```
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ $ ./bazel-bin/heron/tools/ui/src/python/heron-ui
### Heron UI Args

* `--port` - Port to run the heron-ui on. Default port is `8889`.
* `--tracker_url` - The base url for tracker. All the information about the
* `--tracker-url` - The base url for tracker. All the information about the
topologies is fetched from tracker. Default url is `http://localhost:8888`.
* `--address` - Address to listen; Default address is `0.0.0.0`
* `--base_url` - The base url path if operating behind proxy; Default is [`None`](https://github.com/apache/incubator-heron/blob/master/heron/tools/ui/src/python/main.py#L145)
* `--base-url` - The base url path if operating behind proxy; Default is [`None`](https://github.com/apache/incubator-heron/blob/master/heron/tools/ui/src/python/main.py#L145)

```bash
$ heron-ui
# is equivalent to
$ heron-ui --port=8889 --tracker_url=http://localhost:8888
$ heron-ui --port=8889 --tracker-url=http://localhost:8888
```