This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Adding missing logic to Kubernetes Scheduler to properly set the Remote Debug ports #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicknezis
changed the title
thinker0
approved these changes
Aug 1, 2021
joshfischer1108
approved these changes
Aug 1, 2021
| final Config configuration = getConfiguration(); | ||
| final Config runtimeConfiguration = getRuntimeConfiguration(); | ||
| if (TopologyUtils.getTopologyRemoteDebuggingEnabled(Runtime.topology(runtimeConfiguration)) | ||
| && numOfInstances != 0) { |
There was a problem hiding this comment.
Do we want to get rid of this magic number here in the code? It's readable to me, but may not be to others.
There was a problem hiding this comment.
I copied this code from another scheduler. If we change it, we should fix it everywhere. Any name suggestions? My gut feeling is that this one might be obvious, so ok to keep as is.
windhamwong
approved these changes
Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remote debug ports were being added to the Pod Spec, but the logic was never added to provide the port information to the Heron Executor which launches the Java processes.
Also there was an issue with the Kubernetes port name being larger than 15 characters. So I renamed it to fit the K8s spec.