This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
update heron-shell download handler logging #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfischer1108
approved these changes
Sep 30, 2021
nwangtw
reviewed
Oct 1, 2021
| logging.debug("request to download: %s", path) | ||
| handler = logging.StreamHandler() | ||
| handler.setFormatter(anticrlf.LogFormatter('%(levelname)s:%(name)s:%(message)s')) | ||
| logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
I am wondering if we should move this to a class variable so that no need to set the formatter every time.
Maybe not a big deal fro downloader though since downloading doesn't happen very often.
surahman
pushed a commit
to surahman/incubator-heron
that referenced
this pull request
Oct 30, 2021
Co-authored-by: Huijun Wu <huijunw@twitter.com>
This was referenced Dec 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update heron-shell download handler logging