[Heron-3723] Add support for Empty Dir, Host Path, and NFS via CLI #3747

surahman · 2021-12-09T22:21:41Z

Feature #3723: Add support for Empty Dir, Host Path, and NFS via CLI

Closes #3723, Resolves #3723. The duplicate PR is closed #3744 due to tracking the wrong branch (-dev).

This PR adds support for specifying Empty Dir, Host Path, and NFS via CLI commands.

For further details please see the documentation and the relevant section. Please note that the Helm charts and the commands to disable Volumes configuration specification via the CLI has been updated as well.

Commands

~/bin/heron submit kubernetes ~/.heron/examples/heron-api-examples.jar \
org.apache.heron.examples.api.AckingTopology acking \
--verbose \
\
--config-property heron.kubernetes.executor.pod.template=pod-templ-executor.pod-template-executor.yaml \
--config-property heron.kubernetes.manager.pod.template=pod-templ-manager.pod-template-manager.yaml \
\
--config-property heron.kubernetes.manager.limits.cpu=2 \
--config-property heron.kubernetes.manager.limits.memory=3 \
--config-property heron.kubernetes.manager.requests.cpu=1 \
--config-property heron.kubernetes.manager.requests.memory=2 \
\
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-dynamic-volume.claimName=OnDemand \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-dynamic-volume.storageClassName=storage-class-name-manager \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-dynamic-volume.accessModes=ReadWriteOnce,ReadOnlyMany \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-dynamic-volume.sizeLimit=256Gi \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-dynamic-volume.volumeMode=Block \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-dynamic-volume.path=path/to/mount/dynamic/volume \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-dynamic-volume.subPath=sub/path/to/mount/dynamic/volume \
\
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-static-volume.claimName=OnDemand \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-static-volume.accessModes=ReadWriteOnce,ReadOnlyMany \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-static-volume.sizeLimit=512Gi \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-static-volume.volumeMode=Block \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-static-volume.path=path/to/mount/static/volume \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-static-volume.subPath=sub/path/to/mount/static/volume \
\
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-shared-volume.claimName=requested-claim-by-user \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-shared-volume.path=path/to/mount/shared/volume \
--config-property heron.kubernetes.manager.volumes.persistentVolumeClaim.manager-shared-volume.subPath=sub/path/to/mount/shared/volume \
\
--config-property heron.kubernetes.manager.volumes.emptyDir.manager-empty-dir.medium="Memory" \
--config-property heron.kubernetes.manager.volumes.emptyDir.manager-empty-dir.sizeLimit="50Mi" \
--config-property heron.kubernetes.manager.volumes.emptyDir.manager-empty-dir.path="empty/dir/path" \
--config-property heron.kubernetes.manager.volumes.emptyDir.manager-empty-dir.subPath="empty/dir/sub/path" \
--config-property heron.kubernetes.manager.volumes.emptyDir.manager-empty-dir.readOnly="true" \
\
--config-property heron.kubernetes.manager.volumes.hostPath.manager-host-path.type="File" \
--config-property heron.kubernetes.manager.volumes.hostPath.manager-host-path.pathOnHost="/dev/null" \
--config-property heron.kubernetes.manager.volumes.hostPath.manager-host-path.path="host/path/path" \
--config-property heron.kubernetes.manager.volumes.hostPath.manager-host-path.subPath="host/path/sub/path" \
--config-property heron.kubernetes.manager.volumes.hostPath.manager-host-path.readOnly="true" \
\
--config-property heron.kubernetes.manager.volumes.nfs.manager-nfs.server="nfs-server.address" \
--config-property heron.kubernetes.manager.volumes.nfs.manager-nfs.readOnly="true" \
--config-property heron.kubernetes.manager.volumes.nfs.manager-nfs.pathOnNFS="/dev/null" \
--config-property heron.kubernetes.manager.volumes.nfs.manager-nfs.path="nfs/path" \
--config-property heron.kubernetes.manager.volumes.nfs.manager-nfs.subPath="nfs/sub/path" \
--config-property heron.kubernetes.manager.volumes.nfs.manager-nfs.readOnly="true" \
\
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-dynamic-volume.claimName=OnDemand \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-dynamic-volume.storageClassName=storage-class-name-executor \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-dynamic-volume.accessModes=ReadWriteOnce,ReadOnlyMany \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-dynamic-volume.sizeLimit=256Gi \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-dynamic-volume.volumeMode=Block \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-dynamic-volume.path=path/to/mount/dynamic/volume \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-dynamic-volume.subPath=sub/path/to/mount/dynamic/volume \
\
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-static-volume.claimName=OnDemand \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-static-volume.accessModes=ReadWriteOnce,ReadOnlyMany \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-static-volume.sizeLimit=512Gi \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-static-volume.volumeMode=Block \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-static-volume.path=path/to/mount/static/volume \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-static-volume.subPath=sub/path/to/mount/static/volume \
\
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-shared-volume.claimName=requested-claim-by-user \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-shared-volume.path=path/to/mount/shared/volume \
--config-property heron.kubernetes.executor.volumes.persistentVolumeClaim.executor-shared-volume.subPath=sub/path/to/mount/shared/volume

Manager StatefulSet YAML

apiVersion: apps/v1
kind: StatefulSet
metadata:
  creationTimestamp: "2021-12-08T21:38:06Z"
  generation: 1
  labels:
    app: heron
    topology: acking
  name: acking-manager
  namespace: default
  resourceVersion: "2147"
  uid: e3ef4c56-50b6-4a4f-9b0f-fc637dbdceba
spec:
  podManagementPolicy: Parallel
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app: heron
      topology: acking
  serviceName: acking
  template:
    metadata:
      annotations:
        prometheus.io/port: "8080"
        prometheus.io/scrape: "true"
      creationTimestamp: null
      labels:
        app: heron
        topology: acking
    spec:
      containers:
      - command:
        - sh
        - -c
        - './heron-core/bin/heron-downloader-config kubernetes && ./heron-core/bin/heron-downloader
          distributedlog://zookeeper:2181/heronbkdl/acking-saad-tag-0--7412350634992464132.tar.gz
          . && SHARD_ID=${POD_NAME##*-} && echo shardId=${SHARD_ID} && ./heron-core/bin/heron-executor
          --topology-name=acking --topology-id=ackinga54c5c18-7bb1-485a-a4eb-9e16783d2eba
          --topology-defn-file=acking.defn --state-manager-connection=zookeeper:2181
          --state-manager-root=/heron --state-manager-config-file=./heron-conf/statemgr.yaml
          --tmanager-binary=./heron-core/bin/heron-tmanager --stmgr-binary=./heron-core/bin/heron-stmgr
          --metrics-manager-classpath=./heron-core/lib/metricsmgr/* --instance-jvm-opts="LVhYOitIZWFwRHVtcE9uT3V0T2ZNZW1vcnlFcnJvcg(61)(61)"
          --classpath=heron-api-examples.jar --heron-internals-config-file=./heron-conf/heron_internals.yaml
          --override-config-file=./heron-conf/override.yaml --component-ram-map=exclaim1:1073741824,word:1073741824
          --component-jvm-opts="" --pkg-type=jar --topology-binary-file=heron-api-examples.jar
          --heron-java-home=$JAVA_HOME --heron-shell-binary=./heron-core/bin/heron-shell
          --cluster=kubernetes --role=saad --environment=default --instance-classpath=./heron-core/lib/instance/*
          --metrics-sinks-config-file=./heron-conf/metrics_sinks.yaml --scheduler-classpath=./heron-core/lib/scheduler/*:./heron-core/lib/packing/*:./heron-core/lib/statemgr/*
          --python-instance-binary=./heron-core/bin/heron-python-instance --cpp-instance-binary=./heron-core/bin/heron-cpp-instance
          --metricscache-manager-classpath=./heron-core/lib/metricscachemgr/* --metricscache-manager-mode=disabled
          --is-stateful=false --checkpoint-manager-classpath=./heron-core/lib/ckptmgr/*:./heron-core/lib/statefulstorage/*:
          --stateful-config-file=./heron-conf/stateful.yaml --checkpoint-manager-ram=1073741824
          --health-manager-mode=disabled --health-manager-classpath=./heron-core/lib/healthmgr/*
          --shard=$SHARD_ID --server-port=6001 --tmanager-controller-port=6002 --tmanager-stats-port=6003
          --shell-port=6004 --metrics-manager-port=6005 --scheduler-port=6006 --metricscache-manager-server-port=6007
          --metricscache-manager-stats-port=6008 --checkpoint-manager-port=6009'
        env:
        - name: HOST
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: status.podIP
        - name: POD_NAME
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.name
        - name: var_one_manager
          value: variable one on manager
        - name: var_three_manager
          value: variable three on manager
        - name: var_two_manager
          value: variable two on manager
        image: apache/heron:testbuild
        imagePullPolicy: IfNotPresent
        name: manager
        ports:
        - containerPort: 6001
          name: server
          protocol: TCP
        - containerPort: 6002
          name: tmanager-ctl
          protocol: TCP
        - containerPort: 6003
          name: tmanager-stats
          protocol: TCP
        - containerPort: 6004
          name: shell-port
          protocol: TCP
        - containerPort: 6005
          name: metrics-mgr
          protocol: TCP
        - containerPort: 6006
          name: scheduler
          protocol: TCP
        - containerPort: 6007
          name: metrics-cache-m
          protocol: TCP
        - containerPort: 6008
          name: metrics-cache-s
          protocol: TCP
        - containerPort: 6009
          name: ckptmgr
          protocol: TCP
        - containerPort: 7775
          name: tcp-port-kept
          protocol: TCP
        - containerPort: 7776
          name: udp-port-kept
          protocol: UDP
        resources:
          limits:
            cpu: "2"
            memory: "3"
          requests:
            cpu: "1"
            memory: "2"
        securityContext:
          allowPrivilegeEscalation: false
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
        volumeMounts:
        - mountPath: path/to/mount/dynamic/volume
          name: manager-dynamic-volume
          subPath: sub/path/to/mount/dynamic/volume
        - mountPath: empty/dir/path
          name: manager-empty-dir
          readOnly: true
          subPath: empty/dir/sub/path
        - mountPath: host/path/path
          name: manager-host-path
          readOnly: true
          subPath: host/path/sub/path
        - mountPath: nfs/path
          name: manager-nfs
          readOnly: true
          subPath: nfs/sub/path
        - mountPath: path/to/mount/shared/volume
          name: manager-shared-volume
          subPath: sub/path/to/mount/shared/volume
        - mountPath: path/to/mount/static/volume
          name: manager-static-volume
          subPath: sub/path/to/mount/static/volume
        - mountPath: /shared_volume/manager
          name: shared-volume-manager
      - image: alpine
        imagePullPolicy: Always
        name: manager-sidecar-container
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
        volumeMounts:
        - mountPath: /shared_volume/manager
          name: shared-volume-manager
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 0
      tolerations:
      - effect: NoExecute
        key: node.kubernetes.io/not-ready
        operator: Exists
        tolerationSeconds: 10
      - effect: NoExecute
        key: node.kubernetes.io/unreachable
        operator: Exists
        tolerationSeconds: 10
      volumes:
      - emptyDir:
          medium: Memory
          sizeLimit: 50Mi
        name: manager-empty-dir
      - hostPath:
          path: /dev/null
          type: File
        name: manager-host-path
      - name: manager-nfs
        nfs:
          path: /dev/null
          readOnly: true
          server: nfs-server.address
      - name: manager-shared-volume
        persistentVolumeClaim:
          claimName: requested-claim-by-user
      - emptyDir: {}
        name: shared-volume-manager
  updateStrategy:
    rollingUpdate:
      partition: 0
    type: RollingUpdate
  volumeClaimTemplates:
  - apiVersion: v1
    kind: PersistentVolumeClaim
    metadata:
      creationTimestamp: null
      labels:
        onDemand: "true"
        topology: acking
      name: manager-static-volume
    spec:
      accessModes:
      - ReadWriteOnce
      - ReadOnlyMany
      resources:
        requests:
          storage: 512Gi
      storageClassName: ""
      volumeMode: Block
    status:
      phase: Pending
  - apiVersion: v1
    kind: PersistentVolumeClaim
    metadata:
      creationTimestamp: null
      labels:
        onDemand: "true"
        topology: acking
      name: manager-dynamic-volume
    spec:
      accessModes:
      - ReadWriteOnce
      - ReadOnlyMany
      resources:
        requests:
          storage: 256Gi
      storageClassName: storage-class-name-manager
      volumeMode: Block
    status:
      phase: Pending
status:
  collisionCount: 0
  currentReplicas: 1
  currentRevision: acking-manager-7fd976b458
  observedGeneration: 1
  replicas: 1
  updateRevision: acking-manager-7fd976b458
  updatedReplicas: 1

Executor StatefulSet YAML

apiVersion: apps/v1
kind: StatefulSet
metadata:
  creationTimestamp: "2021-12-08T21:38:06Z"
  generation: 1
  labels:
    app: heron
    topology: acking
  name: acking-executors
  namespace: default
  resourceVersion: "2152"
  uid: e63998b2-cfb1-42e5-bc2e-0dfde936b7af
spec:
  podManagementPolicy: Parallel
  replicas: 2
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app: heron
      topology: acking
  serviceName: acking
  template:
    metadata:
      annotations:
        prometheus.io/port: "8080"
        prometheus.io/scrape: "true"
      creationTimestamp: null
      labels:
        app: heron
        topology: acking
    spec:
      containers:
      - command:
        - sh
        - -c
        - './heron-core/bin/heron-downloader-config kubernetes && ./heron-core/bin/heron-downloader
          distributedlog://zookeeper:2181/heronbkdl/acking-saad-tag-0--7412350634992464132.tar.gz
          . && SHARD_ID=$((${POD_NAME##*-} + 1)) && echo shardId=${SHARD_ID} && ./heron-core/bin/heron-executor
          --topology-name=acking --topology-id=ackinga54c5c18-7bb1-485a-a4eb-9e16783d2eba
          --topology-defn-file=acking.defn --state-manager-connection=zookeeper:2181
          --state-manager-root=/heron --state-manager-config-file=./heron-conf/statemgr.yaml
          --tmanager-binary=./heron-core/bin/heron-tmanager --stmgr-binary=./heron-core/bin/heron-stmgr
          --metrics-manager-classpath=./heron-core/lib/metricsmgr/* --instance-jvm-opts="LVhYOitIZWFwRHVtcE9uT3V0T2ZNZW1vcnlFcnJvcg(61)(61)"
          --classpath=heron-api-examples.jar --heron-internals-config-file=./heron-conf/heron_internals.yaml
          --override-config-file=./heron-conf/override.yaml --component-ram-map=exclaim1:1073741824,word:1073741824
          --component-jvm-opts="" --pkg-type=jar --topology-binary-file=heron-api-examples.jar
          --heron-java-home=$JAVA_HOME --heron-shell-binary=./heron-core/bin/heron-shell
          --cluster=kubernetes --role=saad --environment=default --instance-classpath=./heron-core/lib/instance/*
          --metrics-sinks-config-file=./heron-conf/metrics_sinks.yaml --scheduler-classpath=./heron-core/lib/scheduler/*:./heron-core/lib/packing/*:./heron-core/lib/statemgr/*
          --python-instance-binary=./heron-core/bin/heron-python-instance --cpp-instance-binary=./heron-core/bin/heron-cpp-instance
          --metricscache-manager-classpath=./heron-core/lib/metricscachemgr/* --metricscache-manager-mode=disabled
          --is-stateful=false --checkpoint-manager-classpath=./heron-core/lib/ckptmgr/*:./heron-core/lib/statefulstorage/*:
          --stateful-config-file=./heron-conf/stateful.yaml --checkpoint-manager-ram=1073741824
          --health-manager-mode=disabled --health-manager-classpath=./heron-core/lib/healthmgr/*
          --shard=$SHARD_ID --server-port=6001 --tmanager-controller-port=6002 --tmanager-stats-port=6003
          --shell-port=6004 --metrics-manager-port=6005 --scheduler-port=6006 --metricscache-manager-server-port=6007
          --metricscache-manager-stats-port=6008 --checkpoint-manager-port=6009'
        env:
        - name: HOST
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: status.podIP
        - name: POD_NAME
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.name
        - name: var_one
          value: variable one
        - name: var_three
          value: variable three
        - name: var_two
          value: variable two
        image: apache/heron:testbuild
        imagePullPolicy: IfNotPresent
        name: executor
        ports:
        - containerPort: 5555
          name: tcp-port-kept
          protocol: TCP
        - containerPort: 5556
          name: udp-port-kept
          protocol: UDP
        - containerPort: 6001
          name: server
          protocol: TCP
        - containerPort: 6002
          name: tmanager-ctl
          protocol: TCP
        - containerPort: 6003
          name: tmanager-stats
          protocol: TCP
        - containerPort: 6004
          name: shell-port
          protocol: TCP
        - containerPort: 6005
          name: metrics-mgr
          protocol: TCP
        - containerPort: 6006
          name: scheduler
          protocol: TCP
        - containerPort: 6007
          name: metrics-cache-m
          protocol: TCP
        - containerPort: 6008
          name: metrics-cache-s
          protocol: TCP
        - containerPort: 6009
          name: ckptmgr
          protocol: TCP
        resources:
          limits:
            cpu: "3"
            memory: 4Gi
          requests:
            cpu: "3"
            memory: 4Gi
        securityContext:
          allowPrivilegeEscalation: false
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
        volumeMounts:
        - mountPath: path/to/mount/dynamic/volume
          name: executor-dynamic-volume
          subPath: sub/path/to/mount/dynamic/volume
        - mountPath: path/to/mount/shared/volume
          name: executor-shared-volume
          subPath: sub/path/to/mount/shared/volume
        - mountPath: path/to/mount/static/volume
          name: executor-static-volume
          subPath: sub/path/to/mount/static/volume
        - mountPath: /shared_volume
          name: shared-volume
      - image: alpine
        imagePullPolicy: Always
        name: sidecar-container
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
        volumeMounts:
        - mountPath: /shared_volume
          name: shared-volume
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 0
      tolerations:
      - effect: NoExecute
        key: node.kubernetes.io/not-ready
        operator: Exists
        tolerationSeconds: 10
      - effect: NoExecute
        key: node.kubernetes.io/unreachable
        operator: Exists
        tolerationSeconds: 10
      volumes:
      - name: executor-shared-volume
        persistentVolumeClaim:
          claimName: requested-claim-by-user
      - emptyDir: {}
        name: shared-volume
  updateStrategy:
    rollingUpdate:
      partition: 0
    type: RollingUpdate
  volumeClaimTemplates:
  - apiVersion: v1
    kind: PersistentVolumeClaim
    metadata:
      creationTimestamp: null
      labels:
        onDemand: "true"
        topology: acking
      name: executor-dynamic-volume
    spec:
      accessModes:
      - ReadWriteOnce
      - ReadOnlyMany
      resources:
        requests:
          storage: 256Gi
      storageClassName: storage-class-name-executor
      volumeMode: Block
    status:
      phase: Pending
  - apiVersion: v1
    kind: PersistentVolumeClaim
    metadata:
      creationTimestamp: null
      labels:
        onDemand: "true"
        topology: acking
      name: executor-static-volume
    spec:
      accessModes:
      - ReadWriteOnce
      - ReadOnlyMany
      resources:
        requests:
          storage: 512Gi
      storageClassName: ""
      volumeMode: Block
    status:
      phase: Pending
status:
  collisionCount: 0
  currentReplicas: 2
  currentRevision: acking-executors-786f58c8f
  observedGeneration: 1
  replicas: 2
  updateRevision: acking-executors-786f58c8f
  updatedReplicas: 2

heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/V1Controller.java

heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/KubernetesContext.java

joshfischer1108

LGTM. @windhamwong / @nicknezis / @nwangtw can you check this PR?

joshfischer1108 · 2021-12-15T17:26:56Z

Ping @nwangtw @nicknezis @windhamwong @nlu90 @huijunw . Please review if you can.

surahman · 2021-12-15T17:47:44Z

@nicknezis when you have some free time, please review. I think this might have been some functionality you needed.

surahman · 2021-12-17T20:57:39Z

The most recent merge does not change any functionality. It only updates logging in the constructor of the V1Controller to indicate warnings for Pod Template and Volume configuration enabled/disabled.

Refactored <VolumeConfigKeys> and added keys required for hostPath, nfs, and emptyPath support. Cleaned up references in other routines. cleanup

Generic <getVolumeConfigs> to collect all Volume configs from CLI.

Generic test cases and errors for <getVolumeConfigs>.

<getVolumeClaimTemplates> refactored to only check for required PVC parameters. <getVolumeConfigs> collects configs from CLI.

Parameter validation added/moved to <getVolumeClaimTemplates>.

Added passing test cases for <getVolumeClaimTemplates>.

Added keys for: - emptyDir - hostPath - nfs

Added <getVolumeEmptyDir> to collect emptyDir configs.

<getVolumeEmptyDir> tests for errors and valid input.

Moved required path check to <getVolumeConfigs>.

emptyDir valid options check added.

<getVolumeHostPath> collects and validates Host Path CLI options.

<getVolumeHostPath> tests for errors and valid input.

<getVolumeNFS> collects and validates NFS from CLI options.

<getVolumeNFS> tests for errors and valid input.

Added paths for hostPath and NFS.

<getVolumeHostPath> will check for a required Path on the Host.

Bug fixes in error test case loop.

<getVolumeNFS> will check for a required Path on the NFS server.

Generic Volume Mount creation in <createVolumeMountsCLI>.

Generating Volumes and Mounts: - <createVolumeAndMountsEmptyDirCLI> - <createVolumeAndMountsHostPathCLI> - <createVolumeAndMountsNFSCLI>

<createVolumeAndMountsPVCCLI> will append to volumes and mounts. TODO: replace <createPersistentVolumeClaimVolumesAndMounts>

Updated to support disabling of Volume configs from CLI. Flag switched to <heron.kubernetes.volume.from.cli.disabled>.

Creating Volumes and Volume Mounts in from CLI configurations in <createStatefulSet>.

<configurePodWithVolumesAndMountsFromCLI> will merge Volumes and Mounts from CLI configurations.

Updated <createPersistentVolumeClaims> to set a Storage Class name of "" to disable dynamic allocation.

Added option for "readOnly" Volume Mounts in <createVolumeMountsCLI>.

Added instructions for: - Empty Dir - Host Path - NFS

Moved <createVolumeAndMountsPersistentVolumeClaimCLI> up.

@joshfischer1108

Reviewer(s): @joshfischer1108

@joshfischer1108

Reviewer(s): @joshfischer1108

<getVolumeConfigs> needs to check for disabled functionality after trying to collect parameters. It should only error if they are parameters supplied and functionality is disabled.

Removed in document index as Docusaurus already provides an index.

Updated warning messages for Pod Template and Volume configuration in constructor.

…Path-nfs

nicknezis · 2021-12-19T02:44:41Z

Tested both EmptyDir and HostPath. I didn't test NFS, but the logic is all similar so I'm very confident that it will work similarly to the other two new options. Thank you for these awesome additions!

surahman · 2021-12-19T02:58:38Z

You are most welcome and thank you for taking the time to test and review these @nicknezis and @joshfischer1108. I shall wait till tomorrow evening to merge. I do not think there is a need for me to rebase this atop #3749, the merges should interleave the changes from the two PRs.

I am going to bring in a documentation notice update into this PR with warning information on the Host Path - there will be no functional changes in the merge.

…Path-nfs

website2/docs/schedulers-k8s-execution-environment.md

surahman added enhancement cli Kubernetes labels Dec 9, 2021

surahman mentioned this pull request Dec 9, 2021

[Heron-3723] Add support for Empty Dir, Host Path, and NFS via CLI -- Closed, please see #3747. #3744

Closed

surahman force-pushed the 3723-emptyDir-hostPath-nfs branch from aae2f0f to c74318e Compare December 9, 2021 23:31

joshfischer1108 reviewed Dec 10, 2021

View reviewed changes

joshfischer1108 approved these changes Dec 12, 2021

View reviewed changes

surahman added 18 commits December 18, 2021 14:47

[Kubernetes] <Constants>

c03bebb

Refactored <VolumeConfigKeys> and added keys required for hostPath, nfs, and emptyPath support. Cleaned up references in other routines. cleanup

[Kubernetes] <Context>

df3c7dc

Generic <getVolumeConfigs> to collect all Volume configs from CLI.

[Tests] <Context>

2918002

Generic test cases and errors for <getVolumeConfigs>.

[Kubernetes] <Context>

e6cca1d

<getVolumeClaimTemplates> refactored to only check for required PVC parameters. <getVolumeConfigs> collects configs from CLI.

[Kubernetes] <Context>

999c529

Parameter validation added/moved to <getVolumeClaimTemplates>.

[Tests] <Context>

bd3dd8c

Added passing test cases for <getVolumeClaimTemplates>.

[Kubernetes] <Context>

71ba187

Added keys for: - emptyDir - hostPath - nfs

[Kubernetes] <Context>

a0c9e14

Added <getVolumeEmptyDir> to collect emptyDir configs.

[Tests] <Context>

8fb2d13

<getVolumeEmptyDir> tests for errors and valid input.

[Kubernetes] <Context>

5858d1f

Moved required path check to <getVolumeConfigs>.

[Kubernetes] <Controller>

12f0096

emptyDir valid options check added.

[Kubernetes] <Context>

e07c3a3

<getVolumeHostPath> collects and validates Host Path CLI options.

[Tests] <Context>

413ea33

<getVolumeHostPath> tests for errors and valid input.

[Kubernetes] <Context>

c97c45f

<getVolumeNFS> collects and validates NFS from CLI options.

[Tests] <Context>

b0de770

<getVolumeNFS> tests for errors and valid input.

[Kubernetes] <Constants>

af63c7d

Added paths for hostPath and NFS.

[Kubernetes] <Context>

ccd41ee

<getVolumeHostPath> will check for a required Path on the Host.

[Tests] <Context>

efd41d0

Bug fixes in error test case loop.

surahman added 18 commits December 18, 2021 14:47

[Kubernetes] <Context>

8703408

<getVolumeNFS> will check for a required Path on the NFS server.

[Kubernetes] <V1Controller>

70051d8

Generic Volume Mount creation in <createVolumeMountsCLI>.

[Kubernetes] <V1Controller>

04c925c

Generating Volumes and Mounts: - <createVolumeAndMountsEmptyDirCLI> - <createVolumeAndMountsHostPathCLI> - <createVolumeAndMountsNFSCLI>

[Kubernetes] <V1Controller>

3de987b

<createVolumeAndMountsPVCCLI> will append to volumes and mounts. TODO: replace <createPersistentVolumeClaimVolumesAndMounts>

[Kubernetes] <Context>

355cb87

Updated to support disabling of Volume configs from CLI. Flag switched to <heron.kubernetes.volume.from.cli.disabled>.

[Kubernetes] <V1Controller>

7923e78

Creating Volumes and Volume Mounts in from CLI configurations in <createStatefulSet>.

[Kubernetes] <V1Controller>

cf7af50

<configurePodWithVolumesAndMountsFromCLI> will merge Volumes and Mounts from CLI configurations.

[Kubernetes] <V1Controller>

0c3c4fe

Updated <createPersistentVolumeClaims> to set a Storage Class name of "" to disable dynamic allocation.

[Kubernetes] <V1Controller>

f26e18e

Added option for "readOnly" Volume Mounts in <createVolumeMountsCLI>.

[Docs] Added instructions for standard Volumes via CLI.

0493618

Added instructions for: - Empty Dir - Host Path - NFS

[Docs] adjustments, additions, and corrections.

49ba4bd

[Kubernetes] <V1Controller>

07998dd

Moved <createVolumeAndMountsPersistentVolumeClaimCLI> up.

[Kubernetes] <Context>

cd76ea0

Reviewer(s): @joshfischer1108

[Kubernetes] <V1Controller>

6dba6be

Reviewer(s): @joshfischer1108

[Kubernetes] <Context>

96a282a

<getVolumeConfigs> needs to check for disabled functionality after trying to collect parameters. It should only error if they are parameters supplied and functionality is disabled.

[Docs] switching to Docusaurus index

3568c6b

Removed in document index as Docusaurus already provides an index.

[Kubernetes] <V1Controller>

074c9cc

Updated warning messages for Pod Template and Volume configuration in constructor.

Merge branch '3723-emptyDir-hostPath-nfs-dev' into 3723-emptyDir-host…

5d27280

…Path-nfs

surahman force-pushed the 3723-emptyDir-hostPath-nfs branch from f969120 to 5d27280 Compare December 18, 2021 19:50

[Docs] updated warning on Host Path.

eec06c1

nicknezis approved these changes Dec 19, 2021

View reviewed changes

Merge branch '3723-emptyDir-hostPath-nfs-dev' into 3723-emptyDir-host…

95d6116

…Path-nfs

nicknezis approved these changes Dec 19, 2021

View reviewed changes

website2/docs/schedulers-k8s-execution-environment.md Outdated Show resolved Hide resolved

Update website2/docs/schedulers-k8s-execution-environment.md

b0835cb

nicknezis merged commit fd30626 into apache:master Dec 19, 2021

surahman mentioned this pull request Jan 3, 2022

Kubernetes V1Controller Cleanup #3752

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Heron-3723] Add support for Empty Dir, Host Path, and NFS via CLI #3747

[Heron-3723] Add support for Empty Dir, Host Path, and NFS via CLI #3747

surahman commented Dec 9, 2021 •

edited

Loading

joshfischer1108 left a comment

joshfischer1108 commented Dec 15, 2021

surahman commented Dec 15, 2021

surahman commented Dec 17, 2021

nicknezis commented Dec 19, 2021

surahman commented Dec 19, 2021

[Heron-3723] Add support for Empty Dir, Host Path, and NFS via CLI #3747

[Heron-3723] Add support for Empty Dir, Host Path, and NFS via CLI #3747

Conversation

surahman commented Dec 9, 2021 • edited Loading

joshfischer1108 left a comment

Choose a reason for hiding this comment

joshfischer1108 commented Dec 15, 2021

surahman commented Dec 15, 2021

surahman commented Dec 17, 2021

nicknezis commented Dec 19, 2021

surahman commented Dec 19, 2021

surahman commented Dec 9, 2021 •

edited

Loading