This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Fixed stmgr unittest segfault issue on macOS #3767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in which we deleted an item in a loop which invalidated the iterator. An example can be found here: https://stackoverflow.com/a/4636230
Could update to use the returned
itr
as shown below:But I instead opted for the
map.clear()
because the map values are of typeshared_ptr
.