Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Clean up for the compiling docs #795

Merged
merged 2 commits into from
Aug 15, 2016
Merged

Clean up for the compiling docs #795

merged 2 commits into from
Aug 15, 2016

Conversation

lucperkins
Copy link
Contributor

There are no significant content changes in this PR, but I think that these pages are going to behavily trafficked so I wanted to be sure that they look nice and tidy, have proper code highlighting, etc.

@kramasamy
Copy link
Contributor

@lucperkins - is this still needed?

@objmagic
Copy link
Contributor

objmagic commented Jul 7, 2016

This looks good to me. I think we should merge it.

@taishi8117
Copy link
Contributor

Should we merge this?

@kramasamy
Copy link
Contributor

Let us wait until what @lucperkins says.

On Friday, August 12, 2016, Taishi Nojima notifications@github.com wrote:

Should we merge this?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#795 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAWcRJ_NXxtwrlRf_aXl2967ZXFjC_S2ks5qfWIwgaJpZM4InBFU
.

@lucperkins
Copy link
Contributor Author

@kramasamy @taishi8117 @objmagic Yes, these changes are still valid. Please merge if the changes look okay.

@objmagic objmagic merged commit d8e2bd5 into apache:master Aug 15, 2016
@objmagic objmagic added the docs label Aug 15, 2016
nicknezis pushed a commit that referenced this pull request Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants