Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix outdated manifest version & use project.version instead #119

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

z7658329
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #119 (a8815b3) into master (4dbe157) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage     93.15%   93.15%           
  Complexity       65       65           
=========================================
  Files             9        9           
  Lines           263      263           
  Branches         22       22           
=========================================
  Hits            245      245           
  Misses            8        8           
  Partials         10       10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@imbajin imbajin changed the title feat: manifest version use project.version chore: fix outdated manifest version & use project.version instead Nov 23, 2022
@imbajin imbajin requested review from coderzc and javeme November 23, 2022 03:05
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javeme javeme merged commit 5bc993f into apache:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants