Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adjust docker related desc in readme #306

Merged
merged 5 commits into from
Dec 17, 2023

Conversation

aroundabout
Copy link
Contributor

@aroundabout aroundabout commented Dec 15, 2023

Main Change

adjust docker related desc in readme

@aroundabout aroundabout changed the title doc: add asf docker policy doc: adjust docker related desc in readme Dec 16, 2023
- 下载 toolchain 二进制包
- 源码编译
- 使用 docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 使用 docker
- 使用 docker (更方便**测试**)

@@ -142,6 +115,38 @@ cd apache-hugegraph-hubble-incubating*
bin/start-hubble.sh -d
```

#### 2.3 使用 Docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### 2.3 使用 Docker
#### 2.3 使用 Docker (易于测试)

Comment on lines 120 to 122
> 注意:hugegraph-hubble 的 docker 镜像是一个便捷版本,用于快速启动 hubble,并不是 ASF 官方发布版。你可以从 [ASF Release Distribution Policy](https://infra.apache.org/release-distribution.html#dockerhub) 中得到更多细节。

> 注意:推荐使用 `release tag`(如 `1.0.0`) 以获取稳定版。使用 `latest` tag 可以使用开发中的最新功能。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和之前 README 风格保持一致, 这部分后置

- 下载已编译的压缩包
- 克隆源码编译安装
- 使用 Docker 镜像
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, ditto

Co-authored-by: imbajin <jin@apache.org>
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin merged commit 2c19f98 into apache:master Dec 17, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Dec 17, 2023
---------

Co-authored-by: imbajin <jin@apache.org> 2c19f98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants