Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: double quotes to avoid spaces in grep for validating release #310

Merged
merged 1 commit into from
Dec 23, 2023
Merged

fix: double quotes to avoid spaces in grep for validating release #310

merged 1 commit into from
Dec 23, 2023

Conversation

VGalaxies
Copy link
Contributor

As title, if double quotes are not added, an error will occur during grep:

grep: License|BSD-4-Clause|\bBCL\b|JSR-275|Amazon: No such file or directory
grep: Software: No such file or directory
grep: License|\bRSAL\b|\bQPL\b|\bSSPL|\bCPOL|\bNPL1|Creative: No such file or directory
grep: Commons: No such file or directory
grep: Non-Commercial: No such file or directory

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 22, 2023
imbajin
imbajin reviewed Dec 23, 2023
View reviewed changes
dist/validate-release.sh
Comment on lines +214 to +215
#rm -rf ./*src*
#ls -lh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I previously modified the traversal semantics of step 7, skipping the detection of source packages. Therefore, even if the intermediate artifacts from the previous steps are not deleted, it does not affect the detection process.

The intermediate artifacts are retained for ease of manual checking in subsequent steps.

imbajin
imbajin approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 23, 2023
@imbajin imbajin merged commit 3a758ba into apache:master Dec 23, 2023
1 check passed
@imbajin imbajin changed the title fix: add double quotes to avoid the impact of spaces on grep for scripts of validating release fix: double quotes to avoid spaces in grep for validating release Dec 23, 2023
github-actions bot pushed a commit to VGalaxies/incubator-hugegraph-doc that referenced this pull request Dec 23, 2023
@VGalaxies
fix: double quotes to avoid spaces in grep for validating release (ap…
9fe4316 
…ache#310) 3a758ba
@VGalaxies VGalaxies deleted the fix-validate-release branch December 23, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VGalaxies @imbajin