Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(quickstart): computer claim jdk11 #317

Merged
merged 2 commits into from
Dec 28, 2023
Merged

doc(quickstart): computer claim jdk11 #317

merged 2 commits into from
Dec 28, 2023

Conversation

diaohancai
Copy link
Contributor

  1. claim jdk11
  2. re-order title

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Dec 27, 2023
simon824
simon824 reviewed Dec 28, 2023
View reviewed changes
content/en/docs/quickstart/hugegraph-computer.md Outdated
### 2.1 Run PageRank algorithm locally
### 2.1 Install Java 11 (JDK 11)

Consider use Java 11 to run `HugeGraph-Computer` (**not compatible with Java 8 now!!!**), and configure by yourself.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider -> Required to

@diaohancai diaohancai requested a review from simon824 December 28, 2023 06:04
simon824
simon824 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@simon824 simon824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simon824 simon824 merged commit 31b1ffc into apache:master Dec 28, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Dec 28, 2023
@simon824
doc(quickstart): computer claim jdk11 (#317)
13bf2e3 
* doc: claim jdk11

* chore: copywriting adjustment 31b1ffc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon824 simon824 simon824 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diaohancai @simon824