Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hubble): encode/decode Chinese error after building package #627

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(hubble): encode/decode Chinese error after building package #627

merged 1 commit into from
Oct 24, 2024

Conversation

FrostyHec
Copy link
Contributor

@FrostyHec FrostyHec commented Oct 15, 2024 •
edited by imbajin
Loading

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • I add the charset check at initEnv function( in launching), if charset configuration is wrong, it cannot pass the check so that the hubble will throw exception when launching.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 15, 2024
@github-actions github-actions bot added the hubble hugegraph-hubble label Oct 15, 2024
@imbajin imbajin requested a review from simon824 October 16, 2024 08:59
imbajin
imbajin previously approved these changes Oct 17, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 17, 2024
@imbajin imbajin changed the title fix(hubble): Fix the garbled Chinese display issue in Hubble. fix(hubble): Encode/Decode Chinese error after building package Oct 17, 2024
@imbajin imbajin changed the title fix(hubble): Encode/Decode Chinese error after building package fix(hubble): encode/decode Chinese error after building package Oct 17, 2024
@imbajin imbajin requested a review from VGalaxies October 17, 2024 15:30
@imbajin
Copy link
Member

imbajin commented Oct 17, 2024

image

imbajin
imbajin reviewed Oct 17, 2024
View reviewed changes
hugegraph-hubble/hubble-dist/assembly/static/bin/start-hubble.sh
@@ -42,7 +42,7 @@ for jar in "${LIB_PATH}"/*.jar; do
class_path=${class_path}:${jar}
done

JAVA_OPTS="-Xms512m"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add export xxx for system encoding env?

Also need test the docker version

Copy link
Member

@imbajin imbajin Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could refer:
image

@FrostyHec FrostyHec force-pushed the fix-charset-config branch 2 times, most recently from a37ca2b to 2022ace Compare October 18, 2024 05:12
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 18, 2024
@FrostyHec FrostyHec mentioned this pull request Oct 19, 2024
Open
@VGalaxies VGalaxies merged commit 216c894 into apache:master Oct 24, 2024
9 checks passed
@imbajin imbajin mentioned this pull request Dec 9, 2024
Closed
1 task
imbajin pushed a commit that referenced this pull request Dec 9, 2024
@FrostyHec @imbajin
fix(hubble): encode/decode Chinese error after building package (#627)
c2dcd71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VGalaxies VGalaxies VGalaxies approved these changes

@imbajin imbajin imbajin approved these changes

@simon824 simon824 Awaiting requested review from simon824

Assignees
No one assigned
Labels
hubble hugegraph-hubble lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Hubble 创建属性节点中文，数据库乱码
3 participants
@FrostyHec @imbajin @VGalaxies