Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): serialize source and target label for non-father edge label #628

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

Thespica
Copy link
Contributor

Purpose of the PR

related to apache/incubator-hugegraph#2682

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 17, 2024
@github-actions github-actions bot added the client hugegraph-client label Oct 17, 2024
imbajin
imbajin previously approved these changes Oct 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 17, 2024
imbajin
imbajin previously approved these changes Oct 20, 2024
@imbajin imbajin requested a review from VGalaxies October 20, 2024 14:44
Comment on lines 63 to 64
sourceLabel = null;
targetLabel = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sourceLabel = null;
targetLabel = null;
this.sourceLabel = null;
this.targetLabel = null;

@imbajin imbajin requested a review from VGalaxies October 22, 2024 08:31
@VGalaxies VGalaxies merged commit 1bd2ea0 into apache:master Oct 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client hugegraph-client lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants