Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hubble): support English interface & add a script/doc for it #631

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat(hubble): support English interface & add a script/doc for it #631

merged 1 commit into from
Oct 22, 2024

Conversation

FrostyHec
Copy link
Contributor

@FrostyHec FrostyHec commented Oct 18, 2024 •
edited
Loading

Purpose of the PR

Main Changes

Developed and used the automated text resource translation tool described in this document for translation
( see https://hugegraph.feishu.cn/wiki/Amkvw6m5oiPDiRk5H32cmrLDnkh?from=from_copylink , waiting to be transferred to wiki?)

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • Can switch to English version to check the correctness

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 18, 2024
@github-actions github-actions bot added the hubble hugegraph-hubble label Oct 18, 2024
@dosubot dosubot bot added the hubble-fe label Oct 18, 2024
@FrostyHec FrostyHec mentioned this pull request Oct 19, 2024
Open
imbajin
imbajin reviewed Oct 20, 2024
View reviewed changes
hugegraph-hubble/hubble-fe/src/i18n/resources/en-US/graph-managment/AsyncTasks.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle EOF for each file (lack one empty line)
image

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 22, 2024
@imbajin imbajin changed the title feat(hubble) Supporting English interface in Hubble feat(hubble): support English interface & add a script/doc for it Oct 22, 2024
@imbajin imbajin requested a review from VGalaxies October 22, 2024 06:37
@VGalaxies VGalaxies merged commit d048802 into apache:master Oct 22, 2024
9 checks passed
imbajin pushed a commit that referenced this pull request Dec 9, 2024
@FrostyHec @imbajin
feat(hubble): support English interface & add a script/doc for it (#631)
26d5f14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VGalaxies VGalaxies VGalaxies approved these changes

@imbajin imbajin imbajin approved these changes

Assignees
No one assigned
Labels
hubble hugegraph-hubble hubble-fe lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Language Change to English Not Working in hugegraph-hubble
3 participants
@FrostyHec @imbajin @VGalaxies