Adding try-with-resources block around PredictionTraverser (#2016)

Co-authored-by: Sagar Rao <sagarrao@Sagars-MacBook-Pro.local>
apache · Nov 15, 2022 · b79a690 · b79a690
1 parent 833ce2f
commit b79a690
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java
@@ -80,9 +80,10 @@ public String get(@Context GraphManager manager,
         Directions dir = Directions.convert(EdgeAPI.parseDirection(direction));
 
         HugeGraph g = graph(manager, graph);
-        PredictionTraverser traverser = new PredictionTraverser(g);
-        double score = traverser.adamicAdar(sourceId, targetId, dir,
-                                            edgeLabel, maxDegree, limit);
-        return JsonUtil.toJson(ImmutableMap.of("adamic_adar", score));
+        try (PredictionTraverser traverser = new PredictionTraverser(g)) {
+            double score = traverser.adamicAdar(sourceId, targetId, dir,
+                                                edgeLabel, maxDegree, limit);
+            return JsonUtil.toJson(ImmutableMap.of("adamic_adar", score));
+        }
     }
 }
diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ResourceAllocationAPI.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ResourceAllocationAPI.java
@@ -80,10 +80,11 @@ public String create(@Context GraphManager manager,
         Directions dir = Directions.convert(EdgeAPI.parseDirection(direction));
 
         HugeGraph g = graph(manager, graph);
-        PredictionTraverser traverser = new PredictionTraverser(g);
-        double score = traverser.resourceAllocation(sourceId, targetId, dir,
-                                                    edgeLabel, maxDegree,
-                                                    limit);
-        return JsonUtil.toJson(ImmutableMap.of("resource_allocation", score));
+        try (PredictionTraverser traverser = new PredictionTraverser(g)) {
+            double score = traverser.resourceAllocation(sourceId, targetId, dir,
+                                                        edgeLabel, maxDegree,
+                                                        limit);
+            return JsonUtil.toJson(ImmutableMap.of("resource_allocation", score));
+        }
     }
 }