Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if master node before schedule gremlin job #1314

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Dec 25, 2020

Change-Id: I9ef3e1f3f4d30ae8b252a53c148b0b0759eff472

Change-Id: I9ef3e1f3f4d30ae8b252a53c148b0b0759eff472
@@ -61,4 +61,8 @@

public void waitUntilAllTasksCompleted(long seconds)
throws TimeoutException;

default public void checkRequirement(String op) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't set default

Change-Id: I5d6b29ce78e896a3a7f483c696f8d0da71d4b784
@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #1314 (c8d9673) into master (f6c9850) will increase coverage by 0.65%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1314      +/-   ##
============================================
+ Coverage     61.67%   62.33%   +0.65%     
- Complexity     5752     5773      +21     
============================================
  Files           377      377              
  Lines         31501    31508       +7     
  Branches       4413     4412       -1     
============================================
+ Hits          19428    19640     +212     
+ Misses        10088     9875     -213     
- Partials       1985     1993       +8     
Impacted Files Coverage Δ Complexity Δ
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java 4.04% <0.00%> (-0.03%) 0.00 <0.00> (ø)
.../main/java/com/baidu/hugegraph/job/JobBuilder.java 100.00% <100.00%> (ø) 12.00 <0.00> (ø)
...om/baidu/hugegraph/task/StandardTaskScheduler.java 77.66% <100.00%> (+0.11%) 87.00 <1.00> (+1.00)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 81.20% <0.00%> (-0.12%) 203.00% <0.00%> (ø%)
.../baidu/hugegraph/backend/query/ConditionQuery.java 86.40% <0.00%> (+0.40%) 106.00% <0.00%> (+1.00%)
.../backend/store/cassandra/CassandraSessionPool.java 57.14% <0.00%> (+1.02%) 11.00% <0.00%> (ø%)
...om/baidu/hugegraph/backend/store/BackendTable.java 73.33% <0.00%> (+48.50%) 11.00% <0.00%> (ø%)
...h/backend/store/scylladb/ScyllaDBTablesWithMV.java 96.03% <0.00%> (+96.03%) 10.00% <0.00%> (+10.00%)
...graph/backend/store/scylladb/ScyllaDBFeatures.java 100.00% <0.00%> (+100.00%) 3.00% <0.00%> (+3.00%)
.../backend/store/scylladb/ScyllaDBStoreProvider.java 100.00% <0.00%> (+100.00%) 7.00% <0.00%> (+7.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c9850...c8d9673. Read the comment docs.

@Linary Linary merged commit 717d93e into master Dec 28, 2020
@Linary Linary deleted the check-before-schedule-job branch December 28, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants