Fix add schema from follower then list all without it #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I3fa86e813fba61b4d77493e78317ebb451e58785
Codecov Report
@@ Coverage Diff @@
## master #1325 +/- ##
============================================
- Coverage 62.33% 62.32% -0.02%
+ Complexity 5771 5770 -1
============================================
Files 377 377
Lines 31535 31550 +15
Branches 4418 4421 +3
============================================
+ Hits 19658 19663 +5
- Misses 9880 9888 +8
- Partials 1997 1999 +2 Continue to review full report at Codecov.
|
javeme
previously approved these changes
Jan 7, 2021
| @@ -124,6 +124,8 @@ private void listenChanges() { | |||
| schema.name()); | |||
| this.nameCache.invalidate(prefixedName); | |||
| } | |||
| // Set the cache all flag of the schema type to false | |||
| this.cachedTypes().put(type, false); | |||
There was a problem hiding this comment.
add method to line 164: private final void resetCachedAll(type)
Change-Id: I8995bbe6604a9c6f50b6fcf89eafeff623fc1313
javeme
reviewed
Jan 11, 2021
| // Set the cache all flag of the schema type to false | ||
| this.cachedTypes().put(type, false); | ||
| } | ||
|
|
Change-Id: Iad9d80cabb3d6a874ac66c52de22cc2682debfca
javeme
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I3fa86e813fba61b4d77493e78317ebb451e58785