auth: fix resource type NONE and add resource type SCHEMA #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iabcac3c931a977cca8ef911615152c09c517bee9
just for role permission, not for required permission Change-Id: Iaaa1a08fbabb8b73a58c5934c742553930251b4a
since STATUS-read can be represented, but STATUS-write can't be Change-Id: I4803c1cd94a1e3f4fcebb9db29340e8e08e72f3f
Change-Id: I5ce1405d5c9ad57f3c4e739d39a5c370dc89e39c
Change-Id: I0433719bfc9885ee12e264c59212cca214e6e624
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
============================================
+ Coverage 62.38% 62.40% +0.01%
- Complexity 5817 5826 +9
============================================
Files 385 385
Lines 31922 31927 +5
Branches 4451 4453 +2
============================================
+ Hits 19916 19925 +9
+ Misses 9984 9982 -2
+ Partials 2022 2020 -2
Continue to review full report at Codecov.
|
houzhizhen
suggested changes
Feb 22, 2021
| Assert.assertTrue(ResourceType.ROOT.match(ResourceType.EDGE)); | ||
| Assert.assertTrue(ResourceType.ROOT.match(ResourceType.VERTEX_LABEL)); | ||
| Assert.assertTrue(ResourceType.ROOT.match(ResourceType.META)); | ||
| Assert.assertTrue(ResourceType.ALL.match(ResourceType.ALL));; |
There was a problem hiding this comment.
duplicate with line 160, ALL -> ROOT
| Assert.assertTrue(ResourceType.ROOT.match(ResourceType.USER_GROUP)); | ||
| Assert.assertTrue(ResourceType.ROOT.match(ResourceType.TARGET)); | ||
| Assert.assertTrue(ResourceType.ROOT.match(ResourceType.METRICS)); | ||
| Assert.assertFalse(ResourceType.ALL.match(ResourceType.ROOT)); |
zhoney
requested changes
Feb 22, 2021
| * Construct required permission such as: | ||
| * $owner=graph1 $action=read | ||
| * (means required read permission of any one resource) | ||
| * maybe also support: |
There was a problem hiding this comment.
add an empty line and ”In the future maybe also support:“
houzhizhen
previously approved these changes
Feb 23, 2021
javeme
force-pushed
the
fix-auth-NONE-permission
branch
from
efd8753 to
4c544cc
Compare
javeme
force-pushed
the
fix-auth-NONE-permission
branch
from
4c544cc to
227e899
Compare
zhoney
approved these changes
Mar 1, 2021
Linary
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.