auth fix: init store password must be not empty #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
reviewed
Mar 22, 2021
| String prompt = "Please input the admin password:"; | ||
| String alertMsg = "password must be not empty"; |
There was a problem hiding this comment.
String prompt => inputPrompt
String alertMsg => String notEmptyPrompt
improve message "The admin password can't be empty"
| System.out.println(alertMsg); | ||
| } | ||
| } while (password.isEmpty()); | ||
| return password; |
There was a problem hiding this comment.
move to line 84, and define password on line 73
javeme
approved these changes
Mar 22, 2021
Linary
approved these changes
Mar 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #1400 +/- ##
============================================
- Coverage 62.05% 62.04% -0.02%
- Complexity 5837 5838 +1
============================================
Files 386 386
Lines 32185 32192 +7
Branches 4494 4495 +1
============================================
+ Hits 19974 19975 +1
- Misses 10178 10185 +7
+ Partials 2033 2032 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.