Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(auth): validate user through cache to avoid duplicate hash calculation #1460

Merged
merged 2 commits into from
May 20, 2021

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented May 19, 2021

Consider use MurmurHash3 (later)

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1460 (b167190) into master (de81038) will increase coverage by 2.48%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1460      +/-   ##
============================================
+ Coverage     59.68%   62.17%   +2.48%     
- Complexity     5715     5862     +147     
============================================
  Files           381      381              
  Lines         32139    32198      +59     
  Branches       4504     4510       +6     
============================================
+ Hits          19183    20019     +836     
+ Misses        10968    10122     -846     
- Partials       1988     2057      +69     
Impacted Files Coverage Δ Complexity Δ
.../com/baidu/hugegraph/auth/StandardAuthManager.java 93.20% <80.00%> (-0.99%) 62.00 <0.00> (ø)
.../java/com/baidu/hugegraph/auth/ResourceObject.java 55.17% <0.00%> (-21.02%) 7.00% <0.00%> (ø%)
...va/com/baidu/hugegraph/task/ServerInfoManager.java 71.34% <0.00%> (-2.25%) 52.00% <0.00%> (ø%)
.../hugegraph/backend/store/rocksdb/RocksDBStore.java 69.61% <0.00%> (-1.79%) 71.00% <0.00%> (+1.00%) ⬇️
...ain/java/com/baidu/hugegraph/task/TaskManager.java 70.50% <0.00%> (-1.44%) 27.00% <0.00%> (ø%)
...a/com/baidu/hugegraph/backend/query/Condition.java 78.10% <0.00%> (-0.37%) 32.00% <0.00%> (ø%)
...ugegraph/backend/store/raft/StoreSnapshotFile.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ugegraph/backend/store/raft/StoreStateMachine.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 81.15% <0.00%> (+0.11%) 203.00% <0.00%> (ø%)
...u/hugegraph/backend/store/mysql/MysqlSessions.java 68.91% <0.00%> (+0.14%) 29.00% <0.00%> (ø%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de81038...b167190. Read the comment docs.

@javeme javeme changed the title refact: cache validate info to avoid duplicate hash calculation perf(auth): validate user through cache to avoid duplicate hash calculation May 20, 2021
@zhoney zhoney merged commit 0fa8cf9 into master May 20, 2021
@zhoney zhoney deleted the enhance-auth-hash-perf branch May 20, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants