add concurrent IntSet/IntMap #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1552 +/- ##
============================================
+ Coverage 66.76% 67.11% +0.34%
- Complexity 7068 7094 +26
============================================
Files 420 422 +2
Lines 34731 35344 +613
Branches 4822 4938 +116
============================================
+ Hits 23189 23720 +531
- Misses 9205 9235 +30
- Partials 2337 2389 +52
Continue to review full report at Codecov.
|
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
javeme
force-pushed
the
concurrent-map
branch
from
5b878b6 to
1d4e584
Compare
|
cassandra: Error: Tests run: 84, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 67.99 s <<< FAILURE! - in com.baidu.hugegraph.api.ApiTestSuite
Error: testPost(com.baidu.hugegraph.api.traversers.MultiNodeShortestPathApiTest) Time elapsed: 13.8 s <<< FAILURE!
java.lang.AssertionError: Response with status 500 and content {"exception":"class java.lang.OutOfMemoryError","message":"Java heap space","cause":""} expected:<200> but was:<500>
at com.baidu.hugegraph.api.traversers.MultiNodeShortestPathApiTest.testPost(MultiNodeShortestPathApiTest.java:65) |
javeme
commented
Dec 16, 2021
Comment on lines
139
to
141
| long bit = ukey & 0x3f; | ||
| long bitmask = 1L << bit; |
There was a problem hiding this comment.
move to inline method
| // return (int) this.size.sum(); | ||
| } | ||
|
|
||
| private long offset(long key) { |
| * - faster 20x than ec IntIntHashSet-segment-lock for 4 threads; | ||
| * - faster 60x than ec IntIntHashSet-global-lock for 4 threads; | ||
| */ | ||
| public static class IntSetByFixedAddr implements IntSet { |
There was a problem hiding this comment.
support segments of IntSetByFixedAddr?
| import io.netty.util.internal.shaded.org.jctools.util.UnsafeAccess; | ||
| import sun.misc.Unsafe; | ||
|
|
||
| public interface IntMap { |
There was a problem hiding this comment.
implement concurrent-int-hashmap
Change-Id: Ib11aebc16569be6ccc8169908d4bf1e4288800f3
Change-Id: I4df9d194b3ccf57a2dd1c19dd3eb32f1bb0944a5
javeme
force-pushed
the
concurrent-map
branch
from
1d4e584 to
469720e
Compare
Change-Id: I964a2f681dc567b32f4d64e5a23f01b5a4c547c8
Change-Id: Ibf1b3f1acea5a0462303abd4325d0ec493898df8
Change-Id: Ia9412711d385db26390288b92ae96c59786ab119
Change-Id: I019566b4a1060731b0395c9b6356f3e7682c085c
Change-Id: I426b97d608015c18ddc4f789045426176e415f39
Change-Id: Iae7ac65f6bdfa1d871ebb2d5c381141fcf2ad613
Change-Id: I83d44a97b7492f9232f36877f70141cda95d26d4
Change-Id: Id41cf7b59832f619394f09ce8980098d81ef7914
Change-Id: I012e13849facdc56c49df43b8928cdcc94d3d90b
Change-Id: If5592b294ea25c46339aae436ad6c396ee6bf5e4
Change-Id: Id161294f1d6455653c70eaa5eb2bc64d9832a1a3
zhoney
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement: #1636