-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: remove early cycle detection & limit max depth #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limit max depth to avoid stackoverflow
Codecov Report
@@ Coverage Diff @@
## master #1723 +/- ##
============================================
+ Coverage 66.55% 66.92% +0.36%
- Complexity 7085 7110 +25
============================================
Files 423 423
Lines 35598 35615 +17
Branches 4959 4963 +4
============================================
+ Hits 23692 23835 +143
+ Misses 9505 9374 -131
- Partials 2401 2406 +5 Continue to review full report at Codecov.
|
coderzc
previously approved these changes
Jan 4, 2022
javeme
reviewed
Jan 5, 2022
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PathsAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PathsAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/PathsTraverser.java
Show resolved
Hide resolved
javeme
approved these changes
Jan 12, 2022
zhoney
approved these changes
Jan 12, 2022
javeme
pushed a commit
that referenced
this pull request
Jan 12, 2022
* remove useless ring detection due to it will remove valid path * limit max depth to 5000 to avoid stackoverflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: maybe we should refactor the recursive findPath to for-loop