Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringEncoding: improve empty bytes decode #1788

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Mar 18, 2022

Change-Id: I6649c70ef63305acb9eada4abf307a099cf4a997

@github-actions
Copy link

github-actions bot commented Mar 18, 2022

CLA Assistant Lite bot Good! All Contributors have signed the CLA.

@javeme
Copy link
Contributor Author

javeme commented Mar 18, 2022

recheck

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #1788 (c663887) into master (035a03e) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             master    #1788    +/-   ##
==========================================
  Coverage     70.92%   70.92%            
+ Complexity      980      693   -287     
==========================================
  Files           446      446            
  Lines         37883    37894    +11     
  Branches       5397     5398     +1     
==========================================
+ Hits          26867    26876     +9     
+ Misses         8289     8285     -4     
- Partials       2727     2733     +6     
Impacted Files Coverage Δ
...idu/hugegraph/backend/store/hbase/HbaseTables.java 88.42% <ø> (ø)
...hugegraph/backend/serializer/BinarySerializer.java 85.71% <36.36%> (-0.39%) ⬇️
...aidu/hugegraph/backend/serializer/BytesBuffer.java 89.18% <80.00%> (+0.07%) ⬆️
...gegraph/backend/serializer/BinaryBackendEntry.java 79.77% <100.00%> (-0.23%) ⬇️
...java/com/baidu/hugegraph/structure/HugeVertex.java 79.15% <100.00%> (-0.21%) ⬇️
.../java/com/baidu/hugegraph/util/StringEncoding.java 85.91% <100.00%> (+0.84%) ⬆️
...om/baidu/hugegraph/api/filter/ExceptionFilter.java 56.73% <0.00%> (-1.93%) ⬇️
...va/com/baidu/hugegraph/util/collection/IntSet.java 73.61% <0.00%> (-1.28%) ⬇️
...va/com/baidu/hugegraph/task/ServerInfoManager.java 77.95% <0.00%> (-0.54%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035a03e...c663887. Read the comment docs.

Change-Id: I6649c70ef63305acb9eada4abf307a099cf4a997
@javeme javeme force-pushed the empty-bytes-decode branch from 61d7798 to c663887 Compare April 6, 2022 09:38
@imbajin imbajin merged commit 345c4c3 into master Apr 16, 2022
@imbajin imbajin deleted the empty-bytes-decode branch April 16, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants