Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't shutdown when starting with exception #1902

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Jun 13, 2022

Change-Id: If312aa4368bfd7af540818bc299ed219f4e9f335

javeme added 2 commits June 13, 2022 20:01
Change-Id: If312aa4368bfd7af540818bc299ed219f4e9f335
Change-Id: Ia0069c683a61ff9cbcb312aeb75d6622bc0e1003
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1902 (68b6de5) into master (2af01bc) will decrease coverage by 0.64%.
The diff coverage is 38.29%.

@@             Coverage Diff              @@
##             master    #1902      +/-   ##
============================================
- Coverage     71.11%   70.47%   -0.65%     
+ Complexity      963      962       -1     
============================================
  Files           452      452              
  Lines         38405    38803     +398     
  Branches       5418     5530     +112     
============================================
+ Hits          27312    27345      +33     
- Misses         8436     8776     +340     
- Partials       2657     2682      +25     
Impacted Files Coverage Δ
...va/com/baidu/hugegraph/task/ServerInfoManager.java 73.25% <0.00%> (-4.07%) ⬇️
...c/main/java/com/baidu/hugegraph/cmd/InitStore.java 0.00% <0.00%> (ø)
...java/com/baidu/hugegraph/dist/HugeGraphServer.java 36.50% <40.00%> (-0.16%) ⬇️
...in/java/com/baidu/hugegraph/core/GraphManager.java 45.18% <42.10%> (-0.62%) ⬇️
.../com/baidu/hugegraph/server/ApplicationConfig.java 88.67% <57.14%> (-4.94%) ⬇️
.../hugegraph/backend/store/rocksdb/RocksDBStore.java 73.32% <80.00%> (-0.18%) ⬇️
...baidu/hugegraph/backend/store/raft/RaftResult.java 81.25% <0.00%> (-18.75%) ⬇️
...aidu/hugegraph/backend/store/raft/RaftClosure.java 44.82% <0.00%> (-17.25%) ⬇️
...hugegraph/backend/store/raft/RaftBackendStore.java 75.26% <0.00%> (-6.46%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af01bc...68b6de5. Read the comment docs.

@javeme javeme merged commit 1d4b834 into master Jul 4, 2022
@javeme javeme deleted the cannt-shutdown-on-exception branch July 4, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants