fix exception of vertex-drop with index #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2181 +/- ##
==========================================
Coverage 65.08% 65.08%
- Complexity 676 977 +301
==========================================
Files 497 497
Lines 40564 40566 +2
Branches 5662 5663 +1
==========================================
+ Hits 26400 26402 +2
- Misses 11549 11551 +2
+ Partials 2615 2613 -2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
javeme
reviewed
Mar 28, 2023
hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphTransaction.java
Outdated
Show resolved
Hide resolved
imbajin
approved these changes
Mar 29, 2023
javeme
approved these changes
Mar 29, 2023
javeme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #2062
According to @javeme 's solution (#2062 (comment)), the id will be filtered during querying vertices and properties will still be null(refer to the screenshot below).
And it works if force loading properties (
forceLoad) beforevertexbeing added toremovedVerticesinGraphTransaction.removeVertex().