feat: support visit of stage repository #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, the issue of missing the common1.0.1 package has been fixed.
|
|
msgui
commented
Sep 2, 2023
There was a problem hiding this comment.
<profiles>
<profile>
<id>stage</id>
<repositories>
<repository>
<id>staged-releases</id>
<url>https://repository.apache.org/content/groups/staging/</url>
</repository>
</repositories>
<pluginRepositories>
<pluginRepository>
<id>staged-releases</id>
<url>https://repository.apache.org/content/groups/staging/</url>
</pluginRepository>
</pluginRepositories>
</profile>
</profiles>
Fix private repository package issue with 'mvn xxx -P stage
(eg: mvn clean compile -U -Dmaven.javadoc.skip=true -ntp -P stage)
the first problem we have to handle them now like in action add： |
msgui
commented
Sep 3, 2023
pom.xml
Outdated
Comment on lines
114
to
123
| <profile> | ||
| <id>exclude-jdk11-modules</id> | ||
| <activation> | ||
| <jdk>11</jdk> | ||
| </activation> | ||
| <modules> | ||
| <module>hugegraph-store</module> | ||
| <module>hugegraph-pd</module> | ||
| </modules> | ||
| </profile> |
There was a problem hiding this comment.
Due to the current support for JDK 11 compilation in the store/pd , it is necessary to exclude these two modules in the JDK 8.
msgui
commented
Sep 3, 2023
Comment on lines
-97
to
-98
| <module>hugegraph-pd</module> | ||
| <module>hugegraph-store</module> |
There was a problem hiding this comment.
exclude jdk11-only modules cc @VGalaxies
Codecov Report
@@ Coverage Diff @@
## pd-store #2305 +/- ##
===========================================
Coverage ? 54.21%
Complexity ? 905
===========================================
Files ? 498
Lines ? 40626
Branches ? 5658
===========================================
Hits ? 22027
Misses ? 16305
Partials ? 2294 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
module：PD Run api test backed：（memory 11，Cassandra 11，scylladb 11，hbase 11，rocksdb 11，mysql 11，build 11） module：PD Run unit test backed：（memory 11，Cassandra 11，scylladb 11，hbase 11，rocksdb 11，mysql 11，postgresql11） module：server Run api test backed：(postgresql11) module：PD Run core test backed：(postgresql11) module：PD Run api test backed：（memory 11，Cassandra 11，scylladb 11，hbase 11，rocksdb 11，mysql 11） Run raft test backed：(rocksdb 8) module：server Run api test backed：(mysql 8) module：server Run core test backed：(postgresql 8，postgresql 11) |
imbajin
reviewed
Sep 5, 2023
Comment on lines
+30
to
+35
| <pluginRepositories> | ||
| <pluginRepository> | ||
| <id>staged-releases</id> | ||
| <url>https://repository.apache.org/content/groups/staging/</url> | ||
| </pluginRepository> | ||
| </pluginRepositories> |
There was a problem hiding this comment.
maybe we don't need it, although we could keep it now
Co-authored-by: imbajin <jin@apache.org>
imbajin
approved these changes
Sep 6, 2023
26 tasks
VGalaxies
added a commit
to VGalaxies/incubator-hugegraph-doc
that referenced
this pull request
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
support visit of stage repository
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need