Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in wait-storage.sh, always wait for storage with default rocksdb #2333

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

aroundabout
Copy link
Contributor

Purpose of the PR

  • fix: Github action execute error in demo repo
    image

Main Changes

Add a condition whether there are no changes about the graph config.
If no changes, then server use the embedded rocksdb to store data without waiting for storage.

Now:
image

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2333 (1061c74) into master (d4b95ca) will decrease coverage by 8.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2333      +/-   ##
============================================
- Coverage     61.50%   53.34%   -8.16%     
- Complexity      494      662     +168     
============================================
  Files           505      505              
  Lines         41902    41902              
  Branches       5817     5817              
============================================
- Hits          25771    22354    -3417     
- Misses        13506    17176    +3670     
+ Partials       2625     2372     -253     

see 150 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@simon824 simon824 merged commit b43526d into apache:master Oct 24, 2023
19 of 21 checks passed
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants